Attachment 59495 Details for Bug 47765 – Fix pixmap.height < 64 case

[patch] Fix pixmap.height < 64 case

0001-r6xx-r9xx-force-1D-tiling-for-buffer-with-height-64.patch (text/plain), 1.35 KB, created by Jerome Glisse on 2012-04-04 15:43:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jerome Glisse

Created: 2012-04-04 15:43:39 UTC

Size: 1.35 KB

patch

obsolete

>From 818e4850e0e8b6a714c814e4da034a47fdde3316 Mon Sep 17 00:00:00 2001
>From: Jerome Glisse <jglisse@redhat.com>
>Date: Wed, 4 Apr 2012 17:08:30 -0400
>Subject: [PATCH] r6xx-r9xx: force 1D tiling for buffer with height < 64
>
>Due to some old kernel issue, height is 8 aligned insided the ddx
>For buffer with height btw 57 & 63 this lead ddx to believe it can
>allocate a 2D tiled surface while mesa will not align height and
>will assume 1D tiled leading to disagreement and rendering issue.
>This patch force buffer with height < 64 to be 1D tiled.
>
>Signed-off-by: Jerome Glisse <jglisse@redhat.com>
>---
> src/radeon_exa.c |    7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/src/radeon_exa.c b/src/radeon_exa.c
>index 99a5806..270dad4 100644
>--- a/src/radeon_exa.c
>+++ b/src/radeon_exa.c
>@@ -511,6 +511,13 @@ void *RADEONEXACreatePixmap2(ScreenPtr pScreen, int width, int height,
> 			surface.last_level = 0;
> 			surface.bpe = cpp;
> 			surface.nsamples = 1;
>+			if (height < 64) {
>+				/* disable 2d tiling for small surface to work around
>+				 * the fact that ddx align height to 8 pixel for old
>+				 * obscure reason i can't remember
>+				 */
>+				tiling &= ~RADEON_TILING_MACRO;
>+			}
> 			surface.flags = RADEON_SURF_SCANOUT;
> 			surface.flags |= RADEON_SURF_SET(RADEON_SURF_TYPE_2D, TYPE);
> 			surface.flags |= RADEON_SURF_SET(RADEON_SURF_MODE_LINEAR, MODE);
>-- 
>1.7.9.3
>

Actions: View | Splinter Review

Attachments on bug 47765: 58939 | 59126 | 59494 | 59495

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.