Attachment 60558 Details for Bug 30422 – _tp_asv_to_vardict: use _tp_boxed_to_variant()

[patch] _tp_asv_to_vardict: use _tp_boxed_to_variant()

tpasvtovardict-use-tpboxedtovariant.patch (text/plain), 1.05 KB, created by Guillaume Desmottes on 2012-04-25 01:30:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2012-04-25 01:30:18 UTC

Size: 1.05 KB

patch

obsolete

>From 8df1325334c7d8bb13efc389dd792548face022b Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Wed, 25 Apr 2012 10:28:24 +0200
>Subject: [PATCH] _tp_asv_to_vardict: use _tp_boxed_to_variant()
>
>https://bugs.freedesktop.org/show_bug.cgi?id=30422
>---
> telepathy-glib/dbus.c |   13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
>diff --git a/telepathy-glib/dbus.c b/telepathy-glib/dbus.c
>index 8b41484..9115385 100644
>--- a/telepathy-glib/dbus.c
>+++ b/telepathy-glib/dbus.c
>@@ -1961,18 +1961,7 @@ tp_asv_dump (GHashTable *asv)
> GVariant *
> _tp_asv_to_vardict (const GHashTable *asv)
> {
>-  GValue v = G_VALUE_INIT;
>-  GVariant *ret;
>-
>-  g_value_init (&v, TP_HASH_TYPE_STRING_VARIANT_MAP);
>-  g_value_set_boxed (&v, asv);
>-
>-  ret = dbus_g_value_build_g_variant (&v);
>-  g_assert (!tp_strdiff (g_variant_get_type_string (ret), "a{sv}"));
>-
>-  g_value_unset (&v);
>-
>-  return g_variant_ref_sink (ret);
>+  return _tp_boxed_to_variant (TP_HASH_TYPE_STRING_VARIANT_MAP, "a{sv}", (gpointer) asv);
> }
> 
> GVariant *
>-- 
>1.7.7.6

Actions: View | Splinter Review

Attachments on bug 30422: 58189 | 58190 | 58191 | 58192 | 58193 | 58194 | 58195 | 59870 | 59871 | 59872 | 60483 | 60557 | 60558 | 60559 | 60560 | 60563 | 60599 | 60785 | 60788 | 60789

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.