Attachment 60583 Details for Bug 48351 – Potential fix

[patch] Potential fix

alloca.patch (text/plain), 1.11 KB, created by Jose Fonseca on 2012-04-25 09:33:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jose Fonseca

Created: 2012-04-25 09:33:52 UTC

Size: 1.11 KB

patch

obsolete

>commit aadeae03411c081e92c6014590dd51e3c49ab1ad
>Author: JosÃ© Fonseca <jfonseca@vmware.com>
>Date:   Wed Apr 25 16:30:06 2012 +0100
>
>    gallivm: Use lp_build_alloca instead of LLVMBuildAlloca on the loop limiter.
>    
>    To ensure that the alloca is at the top of the function body, otherwise
>    LLVM will not eliminate them, causing stack misalignment on 32bits.
>    
>    Reviewed-by: James Benton <jbenton@vmware.com>
>
>diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
>index 8cfcf5d..cca7ef5 100644
>--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
>+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
>@@ -79,10 +79,7 @@ static void lp_exec_mask_init(struct lp_exec_mask *mask, struct lp_build_context
>    mask->exec_mask = mask->ret_mask = mask->break_mask = mask->cont_mask = mask->cond_mask =
>          LLVMConstAllOnes(mask->int_vec_type);
> 
>-   mask->loop_limiter = LLVMBuildAlloca(
>-      builder,
>-      int_type,
>-      "looplimiter");
>+   mask->loop_limiter = lp_build_alloca(bld->gallivm, int_type, "looplimiter");
> 
>    LLVMBuildStore(
>       builder,

Actions: View | Splinter Review

Attachments on bug 48351: 59533 | 60583 | 64626 | 66017 | 66018 | 69195 | 69196 | 69203

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.