Attachment 61392 Details for Bug 49753 – 5/7] McdConnection: don't bother refcounting handles, they're immortal

[patch] 5/7] McdConnection: don't bother refcounting handles, they're immortal

0005-McdConnection-don-t-bother-refcounting-handles-they-.patch (text/plain), 1.33 KB, created by Simon McVittie on 2012-05-10 12:25:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-05-10 12:25:19 UTC

Size: 1.33 KB

patch

obsolete

>From 8abb940f9fd8f9b8f169fdf1357b2b3bece53ff2 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 10 May 2012 16:06:27 +0100
>Subject: [PATCH 5/7] McdConnection: don't bother refcounting handles, they're
> immortal
>
>---
> src/mcd-connection.c |   24 ------------------------
> 1 file changed, 24 deletions(-)
>
>diff --git a/src/mcd-connection.c b/src/mcd-connection.c
>index 0d38e45..7edca5d 100644
>--- a/src/mcd-connection.c
>+++ b/src/mcd-connection.c
>@@ -2692,30 +2692,6 @@ _mcd_connection_presence_info_is_ready (McdConnection *self)
> 
> static void clear_emergency_handles (McdConnectionPrivate *priv)
> {
>-  guint n_handles = 0;
>-
>-  if (priv->emergency.handles != NULL)
>-    n_handles = tp_intset_size (priv->emergency.handles);
>-
>-  /* trawl through the handles and unref them */
>-  if (n_handles > 0)
>-    {
>-      TpIntsetFastIter iter;
>-      TpHandle *handles = g_new0 (TpHandle, n_handles);
>-      TpHandle handle;
>-      guint i = 0;
>-
>-      tp_intset_fast_iter_init (&iter, priv->emergency.handles);
>-
>-      while (tp_intset_fast_iter_next (&iter, &handle))
>-        handles[i++] = handle;
>-
>-      tp_connection_unref_handles (priv->tp_conn, TP_HANDLE_TYPE_CONTACT,
>-          n_handles, handles);
>-
>-      g_free (handles);
>-    }
>-
>   tp_clear_pointer (&priv->emergency.handles, tp_intset_destroy);
> }
> 
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 49753: 61388 | 61389 | 61390 | 61391 | 61392 | 61393 | 61394

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.