Attachment 61536 Details for Bug 48834 – Improve querying time for queries without templates

[patch] Improve querying time for queries without templates

0001-db-reader.vala-single-out-cases-where-the-WHERE-CLAU.patch (text/plain), 1.08 KB, created by Seif Lotfy on 2012-05-12 19:28:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Seif Lotfy

Created: 2012-05-12 19:28:38 UTC

Size: 1.08 KB

patch

obsolete

>From 6716b9299bc31bbdd66be35ba155c2e01acd298f Mon Sep 17 00:00:00 2001
>From: Seif Lotfy <seif@lotfy.com>
>Date: Sun, 13 May 2012 04:21:09 +0200
>Subject: [PATCH] db-reader.vala: single out cases where the WHERE-CLAUSE is
> empty to fix the issue brought up in the commit 1 of bug
> #48834
>
>---
> src/db-reader.vala |   12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/src/db-reader.vala b/src/db-reader.vala
>index f7c996f..b78afbc 100644
>--- a/src/db-reader.vala
>+++ b/src/db-reader.vala
>@@ -586,6 +586,18 @@ public class DbReader : Object
>         string aggregation_sql = "";
>         string order_sql = "";
> 
>+        // Single out cases where the WHERE-CLAUSE is empty to fix the issue
>+        // brought up in the commit 1 of bug #48834
>+        if (where_sql == "")
>+        {
>+            return """
>+                GROUP BY %s
>+                ORDER BY %s
>+                """.printf (
>+                    field,
>+                    order_sql);
>+        }
>+
>         if (count_asc != null)
>         {
>             aggregation_sql = ", COUNT(%s) AS num_events".printf (field);
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 48834: 60204 | 61536 | 61583 | 61650 | 61659 | 63184

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.