Attachment 61545 Details for Bug 49712 – Enable the PLL for !CPT

[patch] Enable the PLL for !CPT

0001-drm-i915-Enable-the-PCH-PLL-for-all-generations-afte.patch (text/plain), 1.62 KB, created by Chris Wilson on 2012-05-13 01:55:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-05-13 01:55:39 UTC

Size: 1.62 KB

patch

obsolete

>From f210def1bdaafcaf3961b51fba232e6adcc506ab Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Sun, 13 May 2012 09:49:57 +0100
>Subject: [PATCH] drm/i915: Enable the PCH PLL for all generations after link
> training
>
>Hidden away within one chipset specific path was the necessary logic to
>turn on the PLL. This needs to be done everywhere in order for us to
>drive any display! As such as soon as we tested on a non-CougarPoint
>chipset, we failed to bring up any DisplayPorts and generated a nice set
>of assertion failures in the process. At least one part of our logic is
>working, the part that assumes that we have no idea what we are doing.
>
>Reported-by: guang.a.yang@intel.com
>References: https://bugs.freedesktop.org/show_bug.cgi?id=49712
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
>---
> drivers/gpu/drm/i915/intel_display.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index a679a9a..d0112ec 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -2887,14 +2887,14 @@ static void ironlake_pch_enable(struct drm_crtc *crtc)
> 	/* For PCH output, training FDI link */
> 	dev_priv->display.fdi_link_train(crtc);
> 
>+	intel_enable_pch_pll(intel_crtc);
>+
> 	if (HAS_PCH_LPT(dev)) {
> 		DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n");
> 		lpt_program_iclkip(crtc);
> 	} else if (HAS_PCH_CPT(dev)) {
> 		u32 sel;
> 
>-		intel_enable_pch_pll(intel_crtc);
>-
> 		temp = I915_READ(PCH_DPLL_SEL);
> 		switch (pipe) {
> 		default:
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 49712: 61317 | 61424 | 61425 | 61545 | 61592 | 61880

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.