Attachment 61718 Details for Bug 44466 – patch w/ workaround attempt

[patch] patch w/ workaround attempt

copy-target-data.diff (text/plain), 1.09 KB, created by Jose Fonseca on 2012-05-16 08:13:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jose Fonseca

Created: 2012-05-16 08:13:04 UTC

Size: 1.09 KB

patch

obsolete

>diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src/gallium/auxiliary/gallivm/lp_bld_init.c
>index 768d935..0aaa95d 100644
>--- a/src/gallium/auxiliary/gallivm/lp_bld_init.c
>+++ b/src/gallium/auxiliary/gallivm/lp_bld_init.c
>@@ -196,6 +196,7 @@ free_gallivm_state(struct gallivm_state *gallivm)
> 
> #if 0
>    /* Don't free the TargetData, it's owned by the exec engine */
>+#else
>    LLVMDisposeTargetData(gallivm->target);
> #endif
> 
>@@ -271,6 +272,21 @@ init_gallivm_state(struct gallivm_state *gallivm)
>    LLVMAddModuleProvider(gallivm->engine, gallivm->provider);//new
> 
>    gallivm->target = LLVMGetExecutionEngineTargetData(gallivm->engine);
>+#if 1
>+   {
>+      /*
>+       * Try to workaround a misterious bug whereby LLVMOffsetOfElement() starts
>+       * giving bogus results (see fdo bug 41791 and 44466);
>+       */
>+
>+      char *data_layout;
>+      data_layout = LLVMCopyStringRepOfTargetData(gallivm->target);
>+      if (data_layout) {
>+         gallivm->target = LLVMCreateTargetData(data_layout);
>+         free(data_layout);
>+      }
>+   }
>+#endif
>    if (!gallivm->target)
>       goto fail;
>

Actions: View | Splinter Review

Attachments on bug 44466: 57881 | 61718 | 61748 | 61766 | 61837

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.