Attachment 62107 Details for Bug 50361 – log-manager: Fix annotations on get_filtered_events

[patch] log-manager: Fix annotations on get_filtered_events

log-manager-Fix-annotations-on-getfilteredevents.patch (text/plain), 1.34 KB, created by Jasper St. Pierre on 2012-05-25 11:42:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jasper St. Pierre

Created: 2012-05-25 11:42:12 UTC

Size: 1.34 KB

patch

obsolete

>From 0b54c64e2625dbfea229ba84454af0b63e8b3319 Mon Sep 17 00:00:00 2001
>From: "Jasper St. Pierre" <jstpierre@mecheye.net>
>Date: Fri, 25 May 2012 14:31:37 -0400
>Subject: [PATCH] log-manager: Fix annotations on get_filtered_events
>
>Both callbacks needs to be marked allow-none, and filter isn't an
>(async scope), it's an (async call).
>
>https://bugs.freedesktop.org/show_bug.cgi?id=50361
>---
> telepathy-logger/log-manager.c |    5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/telepathy-logger/log-manager.c b/telepathy-logger/log-manager.c
>index d37ab85..f11a58e 100644
>--- a/telepathy-logger/log-manager.c
>+++ b/telepathy-logger/log-manager.c
>@@ -1106,9 +1106,10 @@ _get_filtered_events_async_thread (GSimpleAsyncResult *simple,
>  * @target: a non-NULL #TplEntity
>  * @type_mask: event type filter see #TplEventTypeMask
>  * @num_events: number of maximum events to fetch
>- * @filter: (scope async): an optional filter function
>+ * @filter: (scope call) (allow-none): an optional filter function
>  * @filter_user_data: user data to pass to @filter
>- * @callback: (scope async): a callback to call when the request is satisfied
>+ * @callback: (scope async) (allow-none): a callback to call when
>+ * the request is satisfied
>  * @user_data: data to pass to @callback
>  *
>  * Retrieve the most recent @num_event events exchanged with @target.
>-- 
>1.7.10.1

Actions: View | Splinter Review

Attachments on bug 50361: 62106 | 62107 | 62108

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.