Attachment 62319 Details for Bug 50501 – Do not rely on HPD

[patch] Do not rely on HPD

0001-drm-i915-crt-Do-not-rely-upon-the-HPD-presence-pin.patch (text/plain), 1.25 KB, created by Chris Wilson on 2012-05-31 02:19:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-05-31 02:19:45 UTC

Size: 1.25 KB

patch

obsolete

>From 1e050044de79da2a5b8f18dc95a3c9540d2fc78a Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Thu, 31 May 2012 10:13:38 +0100
>Subject: [PATCH] drm/i915/crt: Do not rely upon the HPD presence pin
>
>Whilst most monitors do wire up the HPD presence pin, it seems quite a
>few KVM do not. Therefore if we simply rely on the HPD pin being
>asserted to indicate a connected monitor we fail miserable, so fall back
>to performing a DCC query for the EDID.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50501
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/intel_crt.c |    4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
>index f0223d0..d8d51d9 100644
>--- a/drivers/gpu/drm/i915/intel_crt.c
>+++ b/drivers/gpu/drm/i915/intel_crt.c
>@@ -456,10 +456,8 @@ intel_crt_detect(struct drm_connector *connector, bool force)
> 		if (intel_crt_detect_hotplug(connector)) {
> 			DRM_DEBUG_KMS("CRT detected via hotplug\n");
> 			return connector_status_connected;
>-		} else {
>+		} else
> 			DRM_DEBUG_KMS("CRT not detected via hotplug\n");
>-			return connector_status_disconnected;
>-		}
> 	}
> 
> 	if (intel_crt_detect_ddc(connector))
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 50501: 62285 | 62286 | 62287 | 62292 | 62317 | 62318 | 62319 | 62333 | 62334 | 62862 | 62868 | 62869

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.