Attachment 62968 Details for Bug 51039 – fix memory leaks in act-user patch

[patch] fix memory leaks in act-user patch

0001-lib-fix-memory-leaks-in-act-user.patch (text/plain), 1.23 KB, created by Pavel Vasin on 2012-06-13 08:05:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pavel Vasin

Created: 2012-06-13 08:05:12 UTC

Size: 1.23 KB

patch

obsolete

>From 5417bb6811def9b387ebf99b6794b4a60fbd0c00 Mon Sep 17 00:00:00 2001
>From: Pavel Vasin <rat4vier@gmail.com>
>Date: Wed, 13 Jun 2012 15:56:49 +0400
>Subject: [PATCH] lib: fix memory leaks in act-user
>
>caller must free all of the values returned by g_variant_iter_next()
>---
> src/libaccountsservice/act-user.c |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/src/libaccountsservice/act-user.c b/src/libaccountsservice/act-user.c
>index 02c1070..f42d00d 100644
>--- a/src/libaccountsservice/act-user.c
>+++ b/src/libaccountsservice/act-user.c
>@@ -1063,7 +1063,7 @@ on_get_all_finished (GObject        *object,
>         GError      *error;
>         GVariant    *res;
>         GVariantIter *iter;
>-        const gchar *key;
>+        gchar       *key;
>         GVariant    *value;
> 
>         g_assert (G_IS_DBUS_PROXY (user->object_proxy));
>@@ -1089,6 +1089,8 @@ on_get_all_finished (GObject        *object,
>         g_variant_get (res, "(a{sv})", &iter);
>         while (g_variant_iter_next (iter, "{sv}", &key, &value)) {
>                 collect_props (key, value, user);
>+                g_free (key);
>+                g_variant_unref (value);
>         }
>         g_variant_iter_free (iter);
>         g_variant_unref (res);
>-- 
>1.7.10.2
>

Actions: View | Splinter Review

Attachments on bug 51039: 62968

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.