Attachment 63328 Details for Bug 38828 – Fixes dialog location and current page not being stored properly

[patch] Fixes dialog location and current page not being stored properly

0001-Properly-store-position-and-current-page-settings-fo.patch (text/plain), 1.88 KB, created by Travis Carter on 2012-06-21 17:34:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Travis Carter

Created: 2012-06-21 17:34:56 UTC

Size: 1.88 KB

patch

obsolete

>From 60b62da93a5d04cb5f21bfe315eb79fa6310ac36 Mon Sep 17 00:00:00 2001
>From: Travis Carter <bugs@traviswcarter.com>
>Date: Thu, 21 Jun 2012 19:25:19 -0500
>Subject: [PATCH] Properly store position and current page settings for bot Ok
> and Apply buttons
>
>Change-Id: Iddee68a7b22749db50c8c78613be11c8ba5500c6
>---
> sfx2/source/dialog/tabdlg.cxx |   14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
>index fe4e8be..231e846 100644
>--- a/sfx2/source/dialog/tabdlg.cxx
>+++ b/sfx2/source/dialog/tabdlg.cxx
>@@ -468,11 +468,6 @@ SfxTabDialog::SfxTabDialog
> 
> SfxTabDialog::~SfxTabDialog()
> {
>-    // save settings (screen position and current page)
>-    SvtViewOptions aDlgOpt( E_TABDIALOG, String::CreateFromInt32( nResId ) );
>-    aDlgOpt.SetWindowState(OStringToOUString(GetWindowState(WINDOWSTATE_MASK_POS),RTL_TEXTENCODING_ASCII_US));
>-    aDlgOpt.SetPageID( aTabCtrl.GetCurPageId() );
>-
>     const sal_uInt16 nCount = pImpl->pData->Count();
>     for ( sal_uInt16 i = 0; i < nCount; ++i )
>     {
>@@ -884,6 +879,10 @@ short SfxTabDialog::Ok()
> /*  [Description]
> 
>     Ok handler for the Dialogue.
>+
>+    Dialog's current location and current page are saved for the next time
>+    the dialog is shown.
>+
>     The OutputSet is created and for each page this or the special OutputSet
>     is set by calling the method <SfxTabPage::FillItemSet(SfxItemSet &)>, to
>     insert the entered data by the user into the set.
>@@ -895,6 +894,11 @@ short SfxTabDialog::Ok()
> */
> 
> {
>+    // save settings (screen position and current page)
>+    SvtViewOptions aDlgOpt( E_TABDIALOG, String::CreateFromInt32( nResId ) );
>+    aDlgOpt.SetWindowState(OStringToOUString(GetWindowState(WINDOWSTATE_MASK_POS),RTL_TEXTENCODING_ASCII_US));
>+    aDlgOpt.SetPageID( aTabCtrl.GetCurPageId() );
>+
>     pImpl->bInOK = sal_True;
> 
>     if ( !pOutSet )
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 38828: 63328

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.