Attachment 63333 Details for Bug 51282 – use a DEBUG instead of warning if dbus_bus_add_match failed

[patch] use a DEBUG instead of warning if dbus_bus_add_match failed

use-a-DEBUG-instead-of-warning-if-dbusbusaddmatch-.patch (text/plain), 985 bytes, created by Guillaume Desmottes on 2012-06-22 00:21:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2012-06-22 00:21:27 UTC

Size: 985 bytes

patch

obsolete

>From 433f3feba941a012df2b6497ea859afb262b7e21 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Fri, 22 Jun 2012 09:19:21 +0200
>Subject: [PATCH] use a DEBUG instead of warning if dbus_bus_add_match failed
>
>Also, make the message more explicit to one can check is D-Bus version if he's
>wondering why it failed.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=51282
>---
> src/client-registry.c |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/client-registry.c b/src/client-registry.c
>index 4874182..9176575 100644
>--- a/src/client-registry.c
>+++ b/src/client-registry.c
>@@ -344,7 +344,8 @@ add_match (DBusConnection *conn,
> 
>   if (dbus_error_is_set (&error))
>     {
>-      g_warning ("Could not add %s match rule: %s", msg, error.message);
>+      DEBUG ("Could not add %s match rule (D-Bus 1.6 required): %s",
>+          msg, error.message);
>       dbus_error_free (&error);
>       return FALSE;
>     }
>-- 
>1.7.10.2

Actions: View | Splinter Review

Attachments on bug 51282: 63333 | 63689

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.