Attachment 63751 Details for Bug 51657 – DBusTransport: do not assert that autolaunch address is non-empty

[patch] DBusTransport: do not assert that autolaunch address is non-empty

0001-DBusTransport-do-not-assert-that-autolaunch-address-.patch (text/plain), 1.03 KB, created by Simon McVittie on 2012-07-03 01:31:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-07-03 01:31:50 UTC

Size: 1.03 KB

patch

obsolete

>From 2333a4cb2fad2c8e5c8f33350f74577b48880093 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 3 Jul 2012 09:26:27 +0100
>Subject: [PATCH] DBusTransport: do not assert that autolaunch address is
> non-empty
>
>dbus-launch can apparently return an empty address under certain
>circumstances, and dbus_parse_address() in the next line will return
>a nice DBusError for an empty address rather than aborting the process.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=51657
>Bug-Debian: http://bugs.debian.org/680027
>---
> dbus/dbus-transport.c |    1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/dbus/dbus-transport.c b/dbus/dbus-transport.c
>index ba720f2..6b58fda 100644
>--- a/dbus/dbus-transport.c
>+++ b/dbus/dbus-transport.c
>@@ -253,7 +253,6 @@ check_address (const char *address, DBusError *error)
>   int len, i;
> 
>   _dbus_assert (address != NULL);
>-  _dbus_assert (*address != '\0');
> 
>   if (!dbus_parse_address (address, &entries, &len, error))
>     return NULL;              /* not a valid address */
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 51657: 63751 | 63771

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.