Attachment 63822 Details for Bug 51725 – [from choeger] Use malloc instead of variable sized array

[patch] [from choeger] Use malloc instead of variable sized array

0007-Use-malloc-instead-of-variable-sized-array.patch (text/plain), 1.15 KB, created by Simon McVittie on 2012-07-04 11:09:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-07-04 11:09:54 UTC

Size: 1.15 KB

patch

obsolete

>From 9f86d49a11160819c52e13f137f35b3062768458 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christoph=20H=C3=B6ger?= <christoph.hoeger@tu-berlin.de>
>Date: Sat, 16 Jun 2012 16:54:27 +0200
>Subject: [PATCH 07/14] Use malloc instead of variable sized array
>
>This is not supported by Microsoft
>---
> _dbus_bindings/message-append.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/_dbus_bindings/message-append.c b/_dbus_bindings/message-append.c
>index f4f843b..a8e1f3f 100644
>--- a/_dbus_bindings/message-append.c
>+++ b/_dbus_bindings/message-append.c
>@@ -934,7 +934,7 @@ _message_iter_append_variant(DBusMessageIter *appender, PyObject *obj)
>     dbus_signature_iter_init(&obj_sig_iter, obj_sig_str);
> 
>     { /* scope for variant_iters */
>-        DBusMessageIter variant_iters[variant_level];
>+        DBusMessageIter* variant_iters = malloc(sizeof(DBusMessageIter) * variant_level);
>         long i;
> 
>         for (i = 0; i < variant_level; i++) {
>@@ -984,7 +984,7 @@ _message_iter_append_variant(DBusMessageIter *appender, PyObject *obj)
>                 goto out;
>             }
>         }
>-
>+		free(variant_iters);
>     }
> 
> out:
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 51725: 63818 | 63819 | 63820 | 63821 | 63822 | 63823 | 63824 | 63825 | 63826 | 63827

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.