Attachment 64085 Details for Bug 51463 – fixup backlight #defin

[patch] fixup backlight #defin

0001-drm-i915-fix-up-PCH-backlight-define-mixup.patch (text/plain), 1.13 KB, created by Daniel Vetter on 2012-07-10 22:24:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2012-07-10 22:24:17 UTC

Size: 1.13 KB

patch

obsolete

>From 333e9100d649d94514bc7a7a9ba96ca04a328d88 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Wed, 11 Jul 2012 00:19:02 +0200
>Subject: [PATCH] drm/i915: fix up PCH backlight #define mixup
>
>I so totally suck.
>
>This can cause a black screen if (for whatever example) the bios
>hasn't set this bit itself.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51463
>Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/i915_reg.h |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>index bd1cda2..45c6703 100644
>--- a/drivers/gpu/drm/i915/i915_reg.h
>+++ b/drivers/gpu/drm/i915/i915_reg.h
>@@ -1921,7 +1921,7 @@
> /* PCH CTL1 is totally different, all but the below bits are reserved. CTL2 is
>  * like the normal CTL from gen4 and earlier. Hooray for confusing naming. */
> #define BLC_PWM_PCH_CTL1	0xc8250
>-#define   BLM_PCH_PWM_ENABLE			(1 << 30)
>+#define   BLM_PCH_PWM_ENABLE			(1 << 31)
> #define   BLM_PCH_OVERRIDE_ENABLE		(1 << 30)
> #define   BLM_PCH_POLARITY			(1 << 29)
> #define BLC_PWM_PCH_CTL2	0xc8254
>-- 
>1.7.10.2
>

Actions: View | Splinter Review

Attachments on bug 51463: 63501 | 63502 | 63755 | 63793 | 64085 | 64096 | 64206 | 64251

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.