Attachment 64704 Details for Bug 52424 – use posting reads

[patch] use posting reads

0001-use-posting-reads-instead.patch (text/plain), 1.69 KB, created by Daniel Vetter on 2012-07-26 09:00:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2012-07-26 09:00:00 UTC

Size: 1.69 KB

patch

obsolete

>From d7459237b1839796163f2167d9da4be6d2ea765d Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Thu, 26 Jul 2012 10:57:10 +0200
>Subject: [PATCH] use posting reads instead
>
>---
> drivers/gpu/drm/i915/intel_pm.c |    6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>index 94aabca..58c07cd 100644
>--- a/drivers/gpu/drm/i915/intel_pm.c
>+++ b/drivers/gpu/drm/i915/intel_pm.c
>@@ -3963,6 +3963,7 @@ static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv)
> 		DRM_ERROR("Force wake wait timed out\n");
> 
> 	I915_WRITE_NOTRACE(FORCEWAKE, 1);
>+	POSTING_READ(FORCEWAKE);
> 
> 	if (wait_for_atomic_us((I915_READ_NOTRACE(forcewake_ack) & 1), 500))
> 		DRM_ERROR("Force wake wait timed out\n");
>@@ -3983,6 +3984,7 @@ static void __gen6_gt_force_wake_mt_get(struct drm_i915_private *dev_priv)
> 		DRM_ERROR("Force wake wait timed out\n");
> 
> 	I915_WRITE_NOTRACE(FORCEWAKE_MT, _MASKED_BIT_ENABLE(1));
>+	POSTING_READ(FORCEWAKE_MT);
> 
> 	if (wait_for_atomic_us((I915_READ_NOTRACE(forcewake_ack) & 1), 500))
> 		DRM_ERROR("Force wake wait timed out\n");
>@@ -4018,14 +4020,14 @@ void gen6_gt_check_fifodbg(struct drm_i915_private *dev_priv)
> static void __gen6_gt_force_wake_put(struct drm_i915_private *dev_priv)
> {
> 	I915_WRITE_NOTRACE(FORCEWAKE, 0);
>-	/* The below doubles as a POSTING_READ */
>+	POSTING_READ(FORCEWAKE);
> 	gen6_gt_check_fifodbg(dev_priv);
> }
> 
> static void __gen6_gt_force_wake_mt_put(struct drm_i915_private *dev_priv)
> {
> 	I915_WRITE_NOTRACE(FORCEWAKE_MT, _MASKED_BIT_DISABLE(1));
>-	/* The below doubles as a POSTING_READ */
>+	POSTING_READ(FORCEWAKE_MT);
> 	gen6_gt_check_fifodbg(dev_priv);
> }
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 52424: 64582 | 64646 | 64648 | 64704 | 64706 | 64937 | 65217 | 66255 | 67665 | 68565 | 68772 | 74217 | 74962

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.