Attachment 65151 Details for Bug 53100 – Don't have a second copy of the TpBaseConnection typedef

[patch] Don't have a second copy of the TpBaseConnection typedef

0001-Don-t-have-a-second-copy-of-the-TpBaseConnection-typ.patch (text/plain), 1.33 KB, created by Simon McVittie on 2012-08-06 08:20:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-08-06 08:20:27 UTC

Size: 1.33 KB

patch

obsolete

>From ae3af979ea2c654fcde4f03158abb284e05e6b18 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 6 Aug 2012 09:19:40 +0100
>Subject: [PATCH] Don't have a second copy of the TpBaseConnection typedef
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>N1570 (C11 final draft) Â§6.7.3 says this usage is valid[1] so modern
>gcc doesn't have an option to even warn about it, but this is a recent
>change to the C standard, and older compilers like the one in the
>Android NDK treat it as a fatal error.
>
>[1] "a typedef name may be redefined to denote the same
>type as it currently does, provided that type is not a variably
>modified type"
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53100
>---
> telepathy-glib/base-connection.h |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/telepathy-glib/base-connection.h b/telepathy-glib/base-connection.h
>index b158328..264f642 100644
>--- a/telepathy-glib/base-connection.h
>+++ b/telepathy-glib/base-connection.h
>@@ -38,7 +38,7 @@
> 
> G_BEGIN_DECLS
> 
>-typedef struct _TpBaseConnection TpBaseConnection;
>+/* The TpBaseConnection typedef is forward-declared in handle-repo.h */
> typedef struct _TpBaseConnectionClass TpBaseConnectionClass;
> typedef struct _TpBaseConnectionPrivate TpBaseConnectionPrivate;
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 53100: 65151

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.