Attachment 65214 Details for Bug 51360 – Hack to try to fix it at the correct place without fallbacks

[patch] Hack to try to fix it at the correct place without fallbacks

0001-Preliminary-patch-for-negative-srcX-and-or-srcY-Pict.patch (text/plain), 1.12 KB, created by Mart Raudsepp on 2012-08-07 01:52:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mart Raudsepp

Created: 2012-08-07 01:52:09 UTC

Size: 1.12 KB

patch

obsolete

>From b448cfa933a219d58374c7787ce0f6103c5a5108 Mon Sep 17 00:00:00 2001
>From: Mart Raudsepp <leio@gentoo.org>
>Date: Tue, 7 Aug 2012 04:42:54 +0300
>Subject: [PATCH] Preliminary patch for negative srcX and/or srcY PictOpSrc
> operations
>
>Needs lots more thought and code path validation, especially in regards to various combinations of operations that it may affect and the while (1) loop afterwards.
>Fixes testcase on bug 51360 at least, but apparently not quite gnome3-panel (some collateral damage in the hack or another issue on top)
>---
> src/lx_exa.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/lx_exa.c b/src/lx_exa.c
>index bcff23e..30b093d 100644
>--- a/src/lx_exa.c
>+++ b/src/lx_exa.c
>@@ -1337,8 +1337,8 @@ lx_do_composite(PixmapPtr pxDst, int srcX, int srcY, int maskX,
>                     opHeight = height;
>                 }
>                 else {
>-                    /* Have not met this condition till now */
>-                    return;
>+                    if (srcX < 0) opX = -srcX;
>+                    if (srcY < 0) opY = -srcY;
>                 }
>             }
>             else {
>-- 
>1.7.8.6
>

Actions: View | Splinter Review

Attachments on bug 51360: 63374 | 65214 | 65250 | 67311

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.