Attachment 65503 Details for Bug 53445 – 3/3] configure.ac: use AS_CASE instead of case/esac

[patch] 3/3] configure.ac: use AS_CASE instead of case/esac

0003-configure.ac-use-AS_CASE-instead-of-case-esac.patch (text/plain), 1.05 KB, created by Simon McVittie on 2012-08-13 16:20:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-08-13 16:20:11 UTC

Size: 1.05 KB

patch

obsolete

>From 37d727e2cd755245be52e52b5f6c2501e0e45eb2 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 13 Aug 2012 11:26:40 +0100
>Subject: [PATCH 3/3] configure.ac: use AS_CASE instead of case/esac
>
>This is the same as AS_IF, but for "case". It's safer for the same
>reasons.
>---
> configure.ac |   12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 75fa543..ac1ea09 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -127,13 +127,11 @@ AS_IF([test "x$enable_fatal_warnings" = xyes],
> 
>   # --no-copy-dt-needed-entries is the new name for --no-add-needed which
>   # is much more widely supported
>-  case "$ERROR_LDFLAGS" in
>-  (*-Wl,--no-copy-dt-needed-entries*)
>-    ;;
>-  (*)
>-    TP_ADD_LINKER_FLAG([ERROR_LDFLAGS], [-Wl,--no-add-needed])
>-    ;;
>-  esac
>+  AS_CASE(["$ERROR_LDFLAGS"],
>+    [*-Wl,--no-copy-dt-needed-entries*],
>+      [],
>+    [*],
>+      [TP_ADD_LINKER_FLAG([ERROR_LDFLAGS], [-Wl,--no-add-needed])])
> ])
> 
> AS_IF([test "x$enable_fatal_warnings" = xyes],
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 53445: 65501 | 65502 | 65503

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.