Attachment 66073 Details for Bug 54016 – fix

[patch] fix

0001-build-fix-for-make-j-safety.patch (text/plain), 1.18 KB, created by Dan Winship on 2012-08-24 16:25:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Winship

Created: 2012-08-24 16:25:13 UTC

Size: 1.18 KB

patch

obsolete

>From beb0977cd41d12e2c7b9c83b6570cb90c0024a2d Mon Sep 17 00:00:00 2001
>From: Dan Winship <danw@gnome.org>
>Date: Fri, 24 Aug 2012 12:19:45 -0400
>Subject: [PATCH] build: fix for "make -j" safety
>
>A make rule with multiple (non-pattern) targets just says that each of
>those files can be built by the rule, not that the rule builds all of
>them at once. So under "make -j", extensions/Makefile would run three
>copies of glib-ginterface-gen.py at once, which could end up deleting
>each others' files and causing a make failure. Fix.
>---
> extensions/Makefile.am | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/extensions/Makefile.am b/extensions/Makefile.am
>index 24efb6e..bb837da 100644
>--- a/extensions/Makefile.am
>+++ b/extensions/Makefile.am
>@@ -42,7 +42,10 @@ extensions.html: _gen/all.xml $(tools_dir)/doc-generator.xsl
> 		$(tools_dir)/doc-generator.xsl \
> 		$< > $@
> 
>-_gen/svc.c _gen/svc.h _gen/svc-gtk-doc.h: _gen/all.xml \
>+_gen/svc.h: _gen/svc.c
>+_gen/svc-gtk-doc.h: _gen/svc.c
>+
>+_gen/svc.c: _gen/all.xml \
> 	$(tools_dir)/glib-ginterface-gen.py
> 	$(AM_V_GEN)$(PYTHON) $(tools_dir)/glib-ginterface-gen.py \
> 		--filename=_gen/svc --signal-marshal-prefix=_idle_ext \
>-- 
>1.7.11.2
>

Actions: View | Splinter Review

Attachments on bug 54016: 66073

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.