Attachment 66361 Details for Bug 42088 – Default account backend: when deleting from the keyring, remove from secrets

[patch] Default account backend: when deleting from the keyring, remove from secrets

0004-Default-account-backend-when-deleting-from-the-keyri.patch (text/plain), 1.17 KB, created by Simon McVittie on 2012-08-30 18:34:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-08-30 18:34:00 UTC

Size: 1.17 KB

patch

obsolete

>From cfe55eece9e3d2d5c8a84d4c6a2a1af704a75f19 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 30 Aug 2012 18:12:06 +0100
>Subject: [PATCH 4/8] Default account backend: when deleting from the keyring,
> remove from secrets
>
>Otherwise we'd just delete it, then (because it's still in secrets)
>re-commit it!
>
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> src/mcd-account-manager-default.c |    2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/src/mcd-account-manager-default.c b/src/mcd-account-manager-default.c
>index 726db5d..71531a8 100644
>--- a/src/mcd-account-manager-default.c
>+++ b/src/mcd-account-manager-default.c
>@@ -78,11 +78,13 @@ _delete_from_keyring (const McpAccountStorage *self,
>       /* flag the whole account as purged */
>       gchar *removed = g_strdup (account);
>       g_hash_table_replace (amd->removed_accounts, removed, removed);
>+      g_key_file_remove_group (amd->secrets, removed, NULL);
>     }
>   else
>     {
>       /* remember to forget this one param */
>       g_key_file_set_value (amd->removed, account, key, "");
>+      g_key_file_remove_key (amd->secrets, account, key, NULL);
>     }
> }
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 42088: 66348 | 66359 | 66360 | 66361 | 66362 | 66363 | 66364 | 66365 | 67272

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.