Attachment 66405 Details for Bug 54322 – Trivial patch fixing the compilation error

[patch] Trivial patch fixing the compilation error

patch (text/plain), 1.01 KB, created by Philippe Liard on 2012-08-31 13:53:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Liard

Created: 2012-08-31 13:53:52 UTC

Size: 1.01 KB

patch

obsolete

>commit 418af8de124b1daa1a82c3af01fa2333476b844c
>Author: Philippe Liard <pliard@google.com>
>Date:   Fri Aug 31 15:45:54 2012 +0200
>
>    Fix build on Clang/ARM r161757 with -Werror.
>    
>    This is raised due to the implicit -Wincompatible-pointer-types.
>
>diff --git a/contrib/harfbuzz-freetype.c b/contrib/harfbuzz-freetype.c
>index a2962df..f6a1e1a 100644
>--- a/contrib/harfbuzz-freetype.c
>+++ b/contrib/harfbuzz-freetype.c
>@@ -21,7 +21,8 @@ hb_freetype_string_to_glyphs(HB_Font font,
>   if (len > *numGlyphs)
>     return 0;
> 
>-  size_t i = 0, j = 0;
>+  ssize_t i = 0;
>+  hb_uint32 j = 0;
>   while (i < len) {
>     const uint32_t cp = utf16_to_code_point(chars, len, &i);
>     glyphs[j++] = FT_Get_Char_Index(face, cp);
>@@ -53,7 +54,7 @@ static HB_Bool
> hb_freetype_can_render(HB_Font font, const HB_UChar16 *chars, hb_uint32 len) {
>   FT_Face face = (FT_Face)font->userData;
> 
>-  size_t i = 0;
>+  ssize_t i = 0;
>   while (i < len) {
>     const uint32_t cp = utf16_to_code_point(chars, len, &i);
>     if (FT_Get_Char_Index(face, cp) == 0)

Actions: View | Splinter Review

Attachments on bug 54322: 66405

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.