Attachment 66421 Details for Bug 54301 – Proposed fix

[patch] Proposed fix

0001-i965-Don-t-leave-dangling-pointer-to-brw-context-on-.patch (text/plain), 1.06 KB, created by Ian Romanick on 2012-08-31 22:03:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Romanick

Created: 2012-08-31 22:03:13 UTC

Size: 1.06 KB

patch

obsolete

>From 85e8518116fc3fa9a30d6b492280dd42354240b8 Mon Sep 17 00:00:00 2001
>From: Ian Romanick <ian.d.romanick@intel.com>
>Date: Fri, 31 Aug 2012 14:55:21 -0700
>Subject: [PATCH] i965: Don't leave dangling pointer to brw context on failure
>
>Otherwise intelDestroyContext would try to dereference the pointer to
>freed memory.
>
>NOTE: This is a candidate for the 9.0 branch.
>
>Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54301
>---
> src/mesa/drivers/dri/i965/brw_context.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
>index 4e5aed6..ab485c3 100644
>--- a/src/mesa/drivers/dri/i965/brw_context.c
>+++ b/src/mesa/drivers/dri/i965/brw_context.c
>@@ -149,6 +149,7 @@ brwCreateContext(int api,
> 			  sharedContextPrivate, &functions )) {
>       printf("%s: failed to init intel context\n", __FUNCTION__);
>       FREE(brw);
>+      driContextPriv->driverPrivate = NULL;
>       *error = __DRI_CTX_ERROR_NO_MEMORY;
>       return false;
>    }
>-- 
>1.7.11.4
>

Actions: View | Splinter Review

Attachments on bug 54301: 66421 | 66700 | 67741

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.