Attachment 66965 Details for Bug 54770 – Patch to amend documentation of dbus_g_thread_init()

[patch] Patch to amend documentation of dbus_g_thread_init()

0001-Amend-dbus_g_thread_init-documentation.patch (text/plain), 1.34 KB, created by Chow Loong Jin on 2012-09-11 11:01:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chow Loong Jin

Created: 2012-09-11 11:01:38 UTC

Size: 1.34 KB

patch

obsolete

>From 9508777d3b14ba1a7fc33346c34ea8e7c24178c3 Mon Sep 17 00:00:00 2001
>From: Chow Loong Jin <hyperair@debian.org>
>Date: Tue, 11 Sep 2012 18:56:04 +0800
>Subject: [PATCH] Amend dbus_g_thread_init() documentation
>
>The documentation specified that dbus_g_thread_init() could only be called once,
>which was untrue, as all it did was call dbus_threads_init_default() which can
>be called as many times as necessary.
>
>This amendment will allow dbus_g_thread_init() to be called from within
>libraries that require multithreaded access to lidbus without violating the API.
>
>One such example is gconf, as seen in BGO #659756.
>
>Signed-off-by: Chow Loong Jin <hyperair@debian.org>
>---
> dbus/dbus-gthread.c |    9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/dbus/dbus-gthread.c b/dbus/dbus-gthread.c
>index 4342864..af52de4 100644
>--- a/dbus/dbus-gthread.c
>+++ b/dbus/dbus-gthread.c
>@@ -33,9 +33,12 @@
>  * dbus_g_thread_init:
>  *
>  * Initializes the D-BUS thread system.
>- * This function may only be called
>- * once and must be called prior to calling any
>- * other function in the D-BUS API.
>+ *
>+ * This function may be called as many times as necessary, but only the first
>+ * time will have any effect.
>+ *
>+ * This function must be called prior to calling any other function in the D-BUS
>+ * API.
>  */
> void
> dbus_g_thread_init (void)
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 54770: 66965

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.