Attachment 67271 Details for Bug 54101 – Destroy CRTCs after planes.

[patch] Destroy CRTCs after planes.

0001-drm-Destroy-the-planes-prior-to-destroying-the-assoc.patch (text/plain), 1.38 KB, created by Chris Wilson on 2012-09-17 09:40:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-09-17 09:40:04 UTC

Size: 1.38 KB

patch

obsolete

>From cc34b6b97723246dbd89151a703476d46f225e72 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 17 Sep 2012 10:33:10 +0100
>Subject: [PATCH] drm: Destroy the planes prior to destroying the associated
> CRTC
>
>As during the plane cleanup, we wish to disable the hardware and
>so may modify state on the associated CRTC, that CRTC must continue to
>exist until we are finished.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54101
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/drm_crtc.c |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
>index 6fbfc24..af81f77 100644
>--- a/drivers/gpu/drm/drm_crtc.c
>+++ b/drivers/gpu/drm/drm_crtc.c
>@@ -1034,15 +1034,15 @@ void drm_mode_config_cleanup(struct drm_device *dev)
> 		fb->funcs->destroy(fb);
> 	}
> 
>-	list_for_each_entry_safe(crtc, ct, &dev->mode_config.crtc_list, head) {
>-		crtc->funcs->destroy(crtc);
>-	}
>-
> 	list_for_each_entry_safe(plane, plt, &dev->mode_config.plane_list,
> 				 head) {
> 		plane->funcs->destroy(plane);
> 	}
> 
>+	list_for_each_entry_safe(crtc, ct, &dev->mode_config.crtc_list, head) {
>+		crtc->funcs->destroy(crtc);
>+	}
>+
> 	idr_remove_all(&dev->mode_config.crtc_idr);
> 	idr_destroy(&dev->mode_config.crtc_idr);
> }
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 54101: 66156 | 67268 | 67271

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.