Attachment 67741 Details for Bug 54301 – The rest of the fix

[patch] The rest of the fix

0002-dri_util-Use-calloc-to-allocate-__DRIcontext.patch (text/plain), 1.15 KB, created by Ian Romanick on 2012-09-26 18:14:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Romanick

Created: 2012-09-26 18:14:40 UTC

Size: 1.15 KB

patch

obsolete

>From 5acdccaa6154b5fbbea320055563b9af2b60e7c2 Mon Sep 17 00:00:00 2001
>From: Ian Romanick <ian.d.romanick@intel.com>
>Date: Wed, 26 Sep 2012 11:08:11 -0700
>Subject: [PATCH 2/2] dri_util: Use calloc to allocate __DRIcontext
>
>The __DRIcontext contains some pointers, and some drivers check for them to be
>NULL in some failure paths.  Instead of sprinkling NULL assignments across the
>various drivers, just zero out the whole thing.
>
>NOTE: This is a candidate for the 9.0 branch.
>
>Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54301
>---
> src/mesa/drivers/dri/common/dri_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
>index 4276ad9..983bbea 100644
>--- a/src/mesa/drivers/dri/common/dri_util.c
>+++ b/src/mesa/drivers/dri/common/dri_util.c
>@@ -272,7 +272,7 @@ dri2CreateContextAttribs(__DRIscreen *screen, int api,
> 	return NULL;
>     }
> 
>-    context = malloc(sizeof *context);
>+    context = calloc(1, sizeof *context);
>     if (!context) {
> 	*error = __DRI_CTX_ERROR_NO_MEMORY;
> 	return NULL;
>-- 
>1.7.11.4
>

Actions: View | Splinter Review

Attachments on bug 54301: 66421 | 66700 | 67741

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.