Attachment 68257 Details for Bug 55666 – [next] TpConnection: don't leak old self-IDs

[patch] [next] TpConnection: don't leak old self-IDs

0003-TpConnection-don-t-leak-old-self-IDs.patch (text/plain), 1.18 KB, created by Simon McVittie on 2012-10-08 13:38:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-10-08 13:38:18 UTC

Size: 1.18 KB

patch

obsolete

>From 9493abc30b6003da3551cc0aea47e37e031f8e36 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 8 Oct 2012 14:26:46 +0100
>Subject: [PATCH 3/7] TpConnection: don't leak old self-IDs
>
>---
> telepathy-glib/connection.c |    2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/telepathy-glib/connection.c b/telepathy-glib/connection.c
>index 9c44f6a..be4d32c 100644
>--- a/telepathy-glib/connection.c
>+++ b/telepathy-glib/connection.c
>@@ -792,6 +792,7 @@ on_self_contact_changed (TpConnection *self,
> 
>   DEBUG ("SelfHandleChanged to %u, I wonder what that means?", self_handle);
>   self->priv->last_known_self_handle = self_handle;
>+  g_free (self->priv->last_known_self_id);
>   self->priv->last_known_self_id = g_strdup (self_id);
> 
>   if (tp_connection_get_status (self, NULL) == TP_CONNECTION_STATUS_CONNECTED)
>@@ -1102,6 +1103,7 @@ _tp_connection_got_properties (TpProxy *proxy,
> 
>       self->priv->introspecting_after_connected = TRUE;
>       self->priv->last_known_self_handle = self_handle;
>+      g_free (self->priv->last_known_self_id);
>       self->priv->last_known_self_id = g_strdup (self_id);
> 
>       self->priv->introspect_needed = g_list_append (
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 55666: 68122 | 68123 | 68124 | 68125 | 68250 | 68255 | 68256 | 68257 | 68258 | 68259 | 68260 | 68261

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.