Attachment 68258 Details for Bug 55666 – [next] TpConnection: correct an outdated comment

[patch] [next] TpConnection: correct an outdated comment

0004-TpConnection-correct-an-outdated-comment.patch (text/plain), 1.02 KB, created by Simon McVittie on 2012-10-08 13:38:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-10-08 13:38:41 UTC

Size: 1.02 KB

patch

obsolete

>From 719906109add0124139e8b56484ed06c70b01631 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 8 Oct 2012 14:27:41 +0100
>Subject: [PATCH 4/7] TpConnection: correct an outdated comment
>
>We previously said "I wonder what that means?" because we'd have to
>inspect the new self-handle to find the new self-ID, but we no longer
>need to do that.
>---
> telepathy-glib/connection.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/telepathy-glib/connection.c b/telepathy-glib/connection.c
>index be4d32c..79c1503 100644
>--- a/telepathy-glib/connection.c
>+++ b/telepathy-glib/connection.c
>@@ -790,7 +790,7 @@ on_self_contact_changed (TpConnection *self,
>       return;
>     }
> 
>-  DEBUG ("SelfHandleChanged to %u, I wonder what that means?", self_handle);
>+  DEBUG ("SelfHandleChanged to %u '%s'", self_handle, self_id);
>   self->priv->last_known_self_handle = self_handle;
>   g_free (self->priv->last_known_self_id);
>   self->priv->last_known_self_id = g_strdup (self_id);
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 55666: 68122 | 68123 | 68124 | 68125 | 68250 | 68255 | 68256 | 68257 | 68258 | 68259 | 68260 | 68261

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.