Attachment 68431 Details for Bug 55047 – fixup ch7xxxx get hw state callback

[patch] fixup ch7xxxx get hw state callback

0001-drm-i915-dvo-ch7xxx-fix-get_hw_state.patch (text/plain), 1.14 KB, created by Daniel Vetter on 2012-10-11 09:11:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2012-10-11 09:11:11 UTC

Size: 1.14 KB

patch

obsolete

>From c462bb40ae55de2178657a985eed077b871f4134 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Thu, 11 Oct 2012 11:09:56 +0200
>Subject: [PATCH] drm/i915/dvo-ch7xxx: fix get_hw_state
>
>The boot-up state seems to be all-zeros, so it's safer to check for
>the bits that need to be set when the dvo encoder is in the dpms on
>state, than checking the bits we set when it's in the off state.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55047
>Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/dvo_ch7xxx.c |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c
>index 38f3a6c..3edd981 100644
>--- a/drivers/gpu/drm/i915/dvo_ch7xxx.c
>+++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c
>@@ -303,10 +303,10 @@ static bool ch7xxx_get_hw_state(struct intel_dvo_device *dvo)
> 
> 	ch7xxx_readb(dvo, CH7xxx_PM, &val);
> 
>-	if (val & CH7xxx_PM_FPD)
>-		return false;
>-	else
>+	if (val & (CH7xxx_PM_DVIL | CH7xxx_PM_DVIP))
> 		return true;
>+	else
>+		return false;
> }
> 
> static void ch7xxx_dump_regs(struct intel_dvo_device *dvo)
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 55047: 67320 | 68428 | 68431 | 68433 | 68442 | 68443 | 68444

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.