Attachment 69456 Details for Bug 56680 – version 2 of 39eac3104c2f08b4d78aab3f88fd104301eb4711

version 2 of 39eac3104c2f08b4d78aab3f88fd104301eb4711

0001-radeon-radeon_platform_probe-fix-Zaphod-mode-breakag.patch (text/plain), 1.55 KB, created by Ilija Hadzic on 2012-11-02 19:11:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ilija Hadzic

Created: 2012-11-02 19:11:30 UTC

Size: 1.55 KB

patch

obsolete

>From 0337d51af5f39f5ea84d0ba17d947df267ff0c2d Mon Sep 17 00:00:00 2001
>From: Ilija Hadzic <ihadzic@research.bell-labs.com>
>Date: Mon, 24 Sep 2012 17:19:09 -0400
>Subject: [PATCH] radeon/radeon_platform_probe: fix Zaphod mode breakage
>
>Using radeon_platform_probe function breaks the Zaphod mode because
>it attempts to call xf86AddEntityToScreen multiple times, but nobody
>calls xf86SetEntityShared prior to that. Consequently, calls for all
>but first device instance fail.
>
>Prior to introduction of platform bus, the logic was that the Probe
>function would make the entity sharable, which would cause Xserver
>to later make it shared prior to adding it to screen. With the
>platform bus loading, add to screen happens in the probe
>function so we have to make it shared there.
>
>v2: do not make the entity shared if it was not previously marked
>    sharable. Should fix:
>
>    https://bugs.freedesktop.org/show_bug.cgi?id=56680
>    https://bugs.freedesktop.org/show_bug.cgi?id=56663
>
>Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
>---
> src/radeon_probe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/src/radeon_probe.c b/src/radeon_probe.c
>index b1471af..2533357 100644
>--- a/src/radeon_probe.c
>+++ b/src/radeon_probe.c
>@@ -278,6 +278,8 @@ radeon_platform_probe(DriverPtr pDriver,
> 	scr_flags = XF86_ALLOCATE_GPU_SCREEN;
> 
>     pScrn = xf86AllocateScreen(pDriver, scr_flags);
>+    if (xf86IsEntitySharable(entity_num))
>+	xf86SetEntityShared(entity_num);
>     xf86AddEntityToScreen(pScrn, entity_num);
> 
>     if (!radeon_kernel_mode_enabled(pScrn, dev->pdev))
>-- 
>1.7.12
>

Actions: View

Attachments on bug 56680: 69446 | 69447 | 69456

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.