Attachment 69485 Details for Bug 56715 – 0002-AES2501-improve-image-contrast.patch

[patch] 0002-AES2501-improve-image-contrast.patch

0002-AES2501-improve-image-contrast.patch (text/plain), 2.68 KB, created by Vasily Khoruzhick on 2012-11-03 13:21:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vasily Khoruzhick

Created: 2012-11-03 13:21:26 UTC

Size: 2.68 KB

patch

obsolete

>From 5cd92165ae26d54933096b1f87b48729f24ef1a6 Mon Sep 17 00:00:00 2001
>From: Vasily Khoruzhick <anarsoul@gmail.com>
>Date: Sat, 3 Nov 2012 16:13:05 +0300
>Subject: [PATCH 2/2] AES2501: improve image contrast
>
>Check histogram sum, increase ADREFHI reg value if sum is too low,
>decrease ADREFHI reg value if it's too high.
>---
> libfprint/drivers/aes2501.c | 17 +++++++++++++++--
> libfprint/drivers/aes2501.h |  6 ++++++
> 2 files changed, 21 insertions(+), 2 deletions(-)
>
>diff --git a/libfprint/drivers/aes2501.c b/libfprint/drivers/aes2501.c
>index f002b93..2a4ecd8 100644
>--- a/libfprint/drivers/aes2501.c
>+++ b/libfprint/drivers/aes2501.c
>@@ -515,13 +515,13 @@ static const struct aes_regwrite capture_reqs_2[] = {
> 	{ AES2501_REG_CTRL2, AES2501_CTRL2_SET_ONE_SHOT },
> };
> 
>-static const struct aes_regwrite strip_scan_reqs[] = {
>+static struct aes_regwrite strip_scan_reqs[] = {
> 	{ AES2501_REG_IMAGCTRL,
> 		AES2501_IMAGCTRL_TST_REG_ENABLE | AES2501_IMAGCTRL_HISTO_DATA_ENABLE },
> 	{ AES2501_REG_STRTCOL, 0x00 },
> 	{ AES2501_REG_ENDCOL, 0x2f },
> 	{ AES2501_REG_CHANGAIN, AES2501_CHANGAIN_STAGE1_16X },
>-	{ AES2501_REG_ADREFHI, 0x5b },
>+	{ AES2501_REG_ADREFHI, AES2501_ADREFHI_MAX_VALUE },
> 	{ AES2501_REG_ADREFLO, 0x20 },
> 	{ AES2501_REG_CTRL2, AES2501_CTRL2_SET_ONE_SHOT },
> };
>@@ -574,6 +574,17 @@ static void capture_read_strip_cb(struct libusb_transfer *transfer)
> 	}
> 	fp_dbg("sum=%d", sum);
> 
>+	if (sum < AES2501_SUM_LOW_THRESH) {
>+		strip_scan_reqs[4].value -= 0x8;
>+		if (strip_scan_reqs[4].value < AES2501_ADREFHI_MIN_VALUE)
>+			strip_scan_reqs[4].value = AES2501_ADREFHI_MIN_VALUE;
>+	} else if (sum > AES2501_SUM_HIGH_THRESH) {
>+		strip_scan_reqs[4].value += 0x8;
>+		if (strip_scan_reqs[4].value > AES2501_ADREFHI_MAX_VALUE)
>+			strip_scan_reqs[4].value = AES2501_ADREFHI_MAX_VALUE;
>+	}
>+	fp_dbg("ADREFHI is %.2x", strip_scan_reqs[4].value);
>+
> 	/* Sum is 0, maybe finger was removed? Wait for 3 empty frames
> 	 * to ensure
> 	 */
>@@ -682,6 +693,8 @@ static void start_capture(struct fp_img_dev *dev)
> 	}
> 
> 	aesdev->no_finger_cnt = 0;
>+	/* Reset gain */
>+	strip_scan_reqs[4].value = AES2501_ADREFHI_MAX_VALUE;
> 	ssm = fpi_ssm_new(dev->dev, capture_run_state, CAPTURE_NUM_STATES);
> 	fp_dbg("");
> 	ssm->priv = dev;
>diff --git a/libfprint/drivers/aes2501.h b/libfprint/drivers/aes2501.h
>index a15699f..9f2f1b6 100644
>--- a/libfprint/drivers/aes2501.h
>+++ b/libfprint/drivers/aes2501.h
>@@ -167,4 +167,10 @@ enum aes2501_sensor_gain2 {
> #define AES2501_LPONT_MIN_VALUE 0x00	/* 0 ms */
> #define AES2501_LPONT_MAX_VALUE 0x1f	/* About 16 ms */
> 
>+#define AES2501_ADREFHI_MIN_VALUE 0x28
>+#define AES2501_ADREFHI_MAX_VALUE 0x58
>+
>+#define AES2501_SUM_HIGH_THRESH 1000
>+#define AES2501_SUM_LOW_THRESH 700
>+
> #endif	/* __AES2501_H */
>-- 
>1.8.0
>

Actions: View | Splinter Review

Attachments on bug 56715: 69484 | 69485 | 69487

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.