Attachment 69544 Details for Bug 56754 – drm/i915/crt: fix DPMS standby and suspend mode handling

[patch] drm/i915/crt: fix DPMS standby and suspend mode handling

0001-drm-i915-crt-fix-DPMS-standby-and-suspend-mode-handl.patch (text/plain), 1.36 KB, created by Jani Nikula on 2012-11-05 08:55:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2012-11-05 08:55:23 UTC

Size: 1.36 KB

patch

obsolete

>From e447d9b349c4e7d185aa6cfe98b4fb175a32dbe7 Mon Sep 17 00:00:00 2001
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Mon, 5 Nov 2012 10:46:25 +0200
>Subject: [PATCH] drm/i915/crt: fix DPMS standby and suspend mode handling
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>PCH platforms and VLV should map DPMS standby and suspend modes to off, but
>due to a buggy reversed comparison this is done on pre-PCH platforms
>instead.
>
>Reported-by: LoÃ¯c Yhuel <loic.yhuel@gmail.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56754
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_crt.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
>index 1c97c27..4cbb9ab 100644
>--- a/drivers/gpu/drm/i915/intel_crt.c
>+++ b/drivers/gpu/drm/i915/intel_crt.c
>@@ -143,7 +143,7 @@ static void intel_crt_dpms(struct drm_connector *connector, int mode)
> 	int old_dpms;
> 
> 	/* PCH platforms and VLV only support on/off. */
>-	if (INTEL_INFO(dev)->gen < 5 && mode != DRM_MODE_DPMS_ON)
>+	if (INTEL_INFO(dev)->gen >= 5 && mode != DRM_MODE_DPMS_ON)
> 		mode = DRM_MODE_DPMS_OFF;
> 
> 	if (mode == connector->dpms)
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 56754: 69544

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.