Attachment 70264 Details for Bug 40711 – test-profile: exit a bit more gracefully

[patch] test-profile: exit a bit more gracefully

0003-test-profile-exit-a-bit-more-gracefully.patch (text/plain), 1.73 KB, created by Simon McVittie on 2012-11-19 16:14:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-11-19 16:14:50 UTC

Size: 1.73 KB

patch

obsolete

>From 9331ccf4a3eff9f18eb849b33948b7013cea8cf5 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 19 Nov 2012 16:12:32 +0000
>Subject: [PATCH 3/3] test-profile: exit a bit more gracefully
>
>We close the connection to ourselves, resulting in libdbus shooting us
>in the head unless we ask it not to. Nice to see how thoroughly this
>code has been tested...
>
>For future reference, it can be tested like this:
>
>    DBUS_TOP_BUILDDIR=$(pwd) ./test/core/run-test.sh profile
>
>(or substitute the real absolute top build directory, if out-of-tree).
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> test/core/test-profile.c |    6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/test/core/test-profile.c b/test/core/test-profile.c
>index ac8870d..cf20bb1 100644
>--- a/test/core/test-profile.c
>+++ b/test/core/test-profile.c
>@@ -206,6 +206,8 @@ no_bus_thread_func (void *data)
>       exit (1);
>     }
> 
>+  dbus_connection_set_exit_on_disconnect (connection, FALSE);
>+
>   context = g_main_context_new ();
> 
>   cd.iterations = 1;
>@@ -376,6 +378,8 @@ with_bus_thread_func (void *data)
>       exit (1);
>     }
> 
>+  dbus_connection_set_exit_on_disconnect (connection, FALSE);
>+
>   if (!dbus_bus_register (connection, &error))
>     {
>       g_printerr ("could not register with bus: %s\n", error.message);
>@@ -531,6 +535,8 @@ with_bus_init_server (ServerData       *sd)
>   
>   connection = dbus_g_connection_get_connection (gconnection);
> 
>+  dbus_connection_set_exit_on_disconnect (connection, FALSE);
>+
>   dbus_bus_request_name (connection,
>                          ECHO_SERVICE,
>                          0, NULL); /* ignore errors because we suck */
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 40711: 51134 | 51135 | 51136 | 51137 | 51138 | 51139 | 51140 | 51141 | 51142 | 51144 | 51145 | 51146 | 51147 | 51148 | 53106 | 53107 | 53108 | 70262 | 70263 | 70264

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.