Attachment 70450 Details for Bug 57426 – 0003-aeslib-prevent-integer-overflow.patch

[patch] 0003-aeslib-prevent-integer-overflow.patch

0003-aeslib-prevent-integer-overflow.patch (text/plain), 982 bytes, created by Vasily Khoruzhick on 2012-11-22 19:30:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vasily Khoruzhick

Created: 2012-11-22 19:30:34 UTC

Size: 982 bytes

patch

obsolete

>From 733a846720b365beed6f16efdcedc6cf30fff91a Mon Sep 17 00:00:00 2001
>From: Vasily Khoruzhick <anarsoul@gmail.com>
>Date: Sun, 18 Nov 2012 11:30:34 +0300
>Subject: [PATCH 3/5] aeslib: prevent integer overflow
>
>AuthenTec devices send 4bpp images, but current code assumes 3bpp for
>some reason.
>---
> libfprint/aeslib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/libfprint/aeslib.c b/libfprint/aeslib.c
>index 0b01d31..00ddfd9 100644
>--- a/libfprint/aeslib.c
>+++ b/libfprint/aeslib.c
>@@ -165,8 +165,8 @@ void aes_assemble_image(unsigned char *input, size_t width, size_t height,
> 
> 	for (column = 0; column < width; column++) {
> 		for (row = 0; row < height; row += 2) {
>-			output[width * row + column] = (*input & 0x07) * 36;
>-			output[width * (row + 1) + column] = ((*input & 0x70) >> 4) * 36;
>+			output[width * row + column] = (*input & 0x0f) * 17;
>+			output[width * (row + 1) + column] = ((*input & 0xf0) >> 4) * 17;
> 			input++;
> 		}
> 	}
>-- 
>1.8.0
>

Actions: View | Splinter Review

Attachments on bug 57426: 70448 | 70449 | 70450 | 70451 | 70452 | 70462 | 70546 | 70547 | 70548 | 70549 | 70550 | 70551 | 70552 | 70553 | 70554

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.