Attachment 70902 Details for Bug 57591 – configure.ac patch

[patch] configure.ac patch

0001-Fix-thread-safety-on-mingw-w64-and-clang.patch (text/plain), 1.10 KB, created by Benjamin Gilbert on 2012-12-02 05:02:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Gilbert

Created: 2012-12-02 05:02:11 UTC

Size: 1.10 KB

patch

obsolete

>From 2966129dfceaf76a3b55b89fb858f2848b7b5baa Mon Sep 17 00:00:00 2001
>From: Benjamin Gilbert <bgilbert@backtick.net>
>Date: Sat, 1 Dec 2012 23:55:31 -0500
>Subject: [PATCH] Fix thread safety on mingw-w64 and clang
>
>After finding a working TLS storage class specifier, configure was
>continuing to test other candidates.  This caused it to prefer
>__declspec(thread) over __thread.  However, __declspec(thread) is
>ignored with a warning by mingw-w64 [1] and silently ignored by clang [2].
>The resulting binary behaved as if PIXMAN_NO_TLS was defined.
>
>Bug introduced by a069da6c.
>
>[1] https://bugs.freedesktop.org/show_bug.cgi?id=57591
>[2] http://lists.freedesktop.org/archives/pixman/2012-October/002320.html
>---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 45b709d..81f068d 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -860,7 +860,7 @@ AC_CACHE_VAL(ac_cv_tls, [
> #error OpenBSD has broken __thread support
> #endif
> 
>-int $kw test;], [], ac_cv_tls=$kw)
>+int $kw test;], [], [ac_cv_tls=$kw; break])
>     done
> ])
> AC_MSG_RESULT($ac_cv_tls)
>-- 
>1.7.11.7
>

Actions: View | Splinter Review

Attachments on bug 57591: 70902

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.