Attachment 73775 Details for Bug 59972 – [PATCH] Allow poppler_page_find_text to be rerun on same page

[PATCH] Allow poppler_page_find_text to be rerun on same page

popper-glib.patch (text/plain), 1.27 KB, created by Rob Cornish on 2013-01-28 14:13:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Cornish

Created: 2013-01-28 14:13:31 UTC

Size: 1.27 KB

patch

obsolete

>From 9f2a7f6ce95815bcabda681978f8ec59e1ec3295 Mon Sep 17 00:00:00 2001
>From: Rob Cornish <jrmcornish@gmail.com>
>Date: Tue, 29 Jan 2013 00:35:00 +1100
>Subject: [PATCH] Allow poppler_page_find_text to be rerun on same page
>
>Fixed a bug that caused poppler_page_find_text always to start searching
>immediately after wherever it had left off in earlier searches. This
>behaviour had the effect that the first call to this function would work
>properly, but any subsequent calls searching for the same string on the
>same page would return NULL.
>---
> glib/poppler-page.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/glib/poppler-page.cc b/glib/poppler-page.cc
>index b88c70b..90c5d8d 100644
>--- a/glib/poppler-page.cc
>+++ b/glib/poppler-page.cc
>@@ -893,7 +893,7 @@ poppler_page_find_text_with_options (PopplerPage     *page,
> 
>   while (text_dev->findText (ucs4, ucs4_len,
>                              gFalse, gTrue, // startAtTop, stopAtBottom
>-                             gTrue, gFalse, // startAtLast, stopAtLast
>+                             gFalse, gFalse, // startAtLast, stopAtLast
>                              options & POPPLER_FIND_CASE_SENSITIVE,
>                              backwards,
>                              options & POPPLER_FIND_WHOLE_WORDS_ONLY,
>-- 
>Rob Cornish
>

Actions: View

Attachments on bug 59972: 73775

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.