Attachment 74679 Details for Bug 60340 – Unix credentials-passing: emit a #warning if we can't

[patch] Unix credentials-passing: emit a #warning if we can't

0002-Unix-credentials-passing-emit-a-warning-if-we-can-t.patch (text/plain), 1.19 KB, created by Simon McVittie on 2013-02-12 13:44:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-02-12 13:44:59 UTC

Size: 1.19 KB

patch

obsolete

>From 6a4299e134a6c84732b2baf43900532bd4f4f33a Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 12 Feb 2013 13:41:58 +0000
>Subject: [PATCH 2/3] Unix credentials-passing: emit a #warning if we can't
>
>This will break the build in developer mode (but not in release mode)
>on platforms where credentials passing doesn't work. That's positive,
>as far as I'm concerned: it'll give developers on obscure platforms
>some incentive to test and fix it.
>
>If we find a Unix OS that really doesn't support credentials-passing,
>we can make this #ifndef __THAT_BAD_UNIX__ or something.
>---
> dbus/dbus-sysdeps-unix.c |    3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c
>index de7cbd9..2b78227 100644
>--- a/dbus/dbus-sysdeps-unix.c
>+++ b/dbus/dbus-sysdeps-unix.c
>@@ -1898,6 +1898,9 @@ _dbus_read_credentials_socket  (int              client_fd,
>     if (ucred != NULL)
>       ucred_free (ucred);
> #else /* !SO_PEERCRED && !HAVE_CMSGCRED && !HAVE_GETPEEREID && !HAVE_GETPEERUCRED */
>+
>+#warning Socket credentials not supported on this Unix OS
>+
>     _dbus_verbose ("Socket credentials not supported on this OS\n");
> #endif
>   }
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 60340: 74261 | 74677 | 74679 | 74680 | 74698 | 75145 | 85786 | 85787 | 85788 | 85789 | 85790 | 85791

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.