Attachment 7530 Details for Bug 7790 – use union's instead of memcpy's

[patch] use union's instead of memcpy's

mach64-vtx-1.patch (text/plain), 1.89 KB, created by George - on 2006-10-26 06:44:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: George -

Created: 2006-10-26 06:44:03 UTC

Size: 1.89 KB

patch

obsolete

>Common subdirectories: mach64/CVS and mach64-tst/CVS
>diff -aup -x '.*' -x 'depend*' -x '*o' mach64/mach64_tris.c mach64-tst/mach64_tris.c
>--- mach64/mach64_tris.c	2006-10-21 01:10:54.000000000 +0300
>+++ mach64-tst/mach64_tris.c	2006-10-25 15:27:53.000000000 +0300
>@@ -1583,7 +1583,10 @@ static void mach64FastRenderClippedPoly(
>    mach64ContextPtr mmesa = MACH64_CONTEXT( ctx );
>    const GLuint vertsize = mmesa->vertex_size;
>    GLint a;
>-   GLfloat ooa;
>+   union {
>+      GLfloat f;
>+      CARD32 u;
>+   } ooa;
>    GLuint xy;
>    const GLuint xyoffset = 9;
>    GLint xx[3], yy[3]; /* 2 fractional bits for hardware */
>@@ -1621,7 +1624,7 @@ static void mach64FastRenderClippedPoly(
>       return;
>    }
>    
>-   ooa = 16.0 / a;
>+   ooa.f = 16.0 / a;
>    
>    vb = (CARD32 *)mach64AllocDmaLow( mmesa, vbsiz * sizeof(CARD32) );
>    vbchk = vb + vbsiz;
>@@ -1629,7 +1632,7 @@ static void mach64FastRenderClippedPoly(
>    COPY_VERTEX( vb, vertsize, v0, 1 );
>    COPY_VERTEX( vb, vertsize, v1, 2 );
>    COPY_VERTEX_OOA( vb, vertsize, v2, 3 );
>-   LE32_OUT( vb++, *(CARD32 *)&ooa );
>+   LE32_OUT( vb++, ooa.u );
> 
>    i = 3;
>    while (1) {
>@@ -1644,10 +1647,10 @@ static void mach64FastRenderClippedPoly(
> 	      
>       a = (xx[0] - xx[2]) * (yy[1] - yy[2]) -
> 	  (yy[0] - yy[2]) * (xx[1] - xx[2]);
>-      ooa = 16.0 / a;
>+      ooa.f = 16.0 / a;
>    
>       COPY_VERTEX_OOA( vb, vertsize, v0, 1 );
>-      LE32_OUT( vb++, *(CARD32 *)&ooa );
>+      LE32_OUT( vb++, ooa.u );
>       
>       if (i >= n)
> 	 break;
>@@ -1660,10 +1663,10 @@ static void mach64FastRenderClippedPoly(
> 	      
>       a = (xx[0] - xx[2]) * (yy[1] - yy[2]) -
> 	  (yy[0] - yy[2]) * (xx[1] - xx[2]);
>-      ooa = 16.0 / a;
>+      ooa.f = 16.0 / a;
>    
>       COPY_VERTEX_OOA( vb, vertsize, v1, 2 );
>-      LE32_OUT( vb++, *(CARD32 *)&ooa );
>+      LE32_OUT( vb++, ooa.u );
>    }
> 
>    assert( vb == vbchk );
>Common subdirectories: mach64/server and mach64-tst/server

Actions: View | Splinter Review

Attachments on bug 7790: 7478 | 7530

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.