Attachment 75962 Details for Bug 56359 – [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

[patch] [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling crt

0001-drm-i915-Turn-off-hsync-and-vsync-on-ADPA-when-disab.patch (text/plain), 1.04 KB, created by Patrik Jakobsson on 2013-03-05 14:47:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrik Jakobsson

Created: 2013-03-05 14:47:01 UTC

Size: 1.04 KB

patch

obsolete

>From cc49cde43e2c499515b26a185862cc4d2ec59fea Mon Sep 17 00:00:00 2001
>From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>Date: Tue, 5 Mar 2013 13:52:07 +0100
>Subject: [PATCH] drm/i915: Turn off hsync and vsync on ADPA when disabling
> crt
>
>According to PRM we need to disable hsync and vsync even though ADPA is
>disabled. The previous code did infact do the opposite so we fix it.
>
>Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>---
> drivers/gpu/drm/i915/intel_crt.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
>index 969d08c..32a3693 100644
>--- a/drivers/gpu/drm/i915/intel_crt.c
>+++ b/drivers/gpu/drm/i915/intel_crt.c
>@@ -88,7 +88,7 @@ static void intel_disable_crt(struct intel_encoder *encoder)
> 	u32 temp;
> 
> 	temp = I915_READ(crt->adpa_reg);
>-	temp &= ~(ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE);
>+	temp |= ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE;
> 	temp &= ~ADPA_DAC_ENABLE;
> 	I915_WRITE(crt->adpa_reg, temp);
> }
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 56359: 69006 | 69007 | 69008 | 69009 | 69010 | 75954 | 75956 | 75962

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.