Attachment 76817 Details for Bug 62369 – check order bounding box values in tiling pattern

[patch] check order bounding box values in tiling pattern

62369.patch (text/plain), 1.19 KB, created by Thomas Freitag on 2013-03-20 14:18:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Freitag

Created: 2013-03-20 14:18:50 UTC

Size: 1.19 KB

patch

obsolete

>diff --git a/poppler/Gfx.cc b/poppler/Gfx.cc
>index 942ad1b..b15ee5f 100644
>--- a/poppler/Gfx.cc
>+++ b/poppler/Gfx.cc
>@@ -2207,10 +2207,20 @@ void Gfx::doTilingPatternFill(GfxTilingPattern *tPat,
>   //~ edge instead of left/bottom (?)
>   xstep = fabs(tPat->getXStep());
>   ystep = fabs(tPat->getYStep());
>-  xi0 = (int)ceil((xMin - tPat->getBBox()[2]) / xstep);
>-  xi1 = (int)floor((xMax - tPat->getBBox()[0]) / xstep) + 1;
>-  yi0 = (int)ceil((yMin - tPat->getBBox()[3]) / ystep);
>-  yi1 = (int)floor((yMax - tPat->getBBox()[1]) / ystep) + 1;
>+  if (tPat->getBBox()[0] < tPat->getBBox()[2]) {
>+    xi0 = (int)ceil((xMin - tPat->getBBox()[2]) / xstep);
>+    xi1 = (int)floor((xMax - tPat->getBBox()[0]) / xstep) + 1;
>+  } else {
>+    xi0 = (int)ceil((xMin - tPat->getBBox()[0]) / xstep);
>+    xi1 = (int)floor((xMax - tPat->getBBox()[2]) / xstep) + 1;
>+  }
>+  if (tPat->getBBox()[1] < tPat->getBBox()[3]) {
>+    yi0 = (int)ceil((yMin - tPat->getBBox()[3]) / ystep);
>+    yi1 = (int)floor((yMax - tPat->getBBox()[1]) / ystep) + 1;
>+  } else {
>+    yi0 = (int)ceil((yMin - tPat->getBBox()[1]) / ystep);
>+    yi1 = (int)floor((yMax - tPat->getBBox()[3]) / ystep) + 1;
>+  }
>   for (i = 0; i < 4; ++i) {
>     m1[i] = m[i];
>   }

Actions: View | Splinter Review

Attachments on bug 62369: 76558 | 76817

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.