Attachment 76922 Details for Bug 62584 – fix for invalid page in sg

[patch] fix for invalid page in sg

0001-drm-i915-set-dummy-page-for-stolen-objects.patch (text/plain), 1.28 KB, created by Imre Deak on 2013-03-22 21:37:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Imre Deak

Created: 2013-03-22 21:37:20 UTC

Size: 1.28 KB

patch

obsolete

>From fd9ccd349df7109502baeacfc9edcb8186c8ca06 Mon Sep 17 00:00:00 2001
>From: Imre Deak <imre.deak@intel.com>
>Date: Fri, 22 Mar 2013 22:59:10 +0200
>Subject: [PATCH] drm/i915: set dummy page for stolen objects
>
>This is needed since currently sg_for_each_page assumes that we have
>a valid page in each sg item. It is only a real problem for
>CONFIG_SPARSEMEM where the page is dereferenced, in other cases the
>iterator works ok with an invalid page pointer.
>
>We can remove this workaround when we have fixed sg_page_iter to work on
>scatterlists without backing pages.
>
>Signed-off-by: Imre Deak <imre.deak@intel.com>
>---
> drivers/gpu/drm/i915/i915_gem_stolen.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
>index 69d97cb..efaaba5 100644
>--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
>+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
>@@ -222,8 +222,8 @@ i915_pages_create_for_stolen(struct drm_device *dev,
> 	}
> 
> 	sg = st->sgl;
>-	sg->offset = offset;
>-	sg->length = size;
>+	/* we set the dummy page here only to make for_each_sg_page work */
>+	sg_set_page(sg, dev_priv->gtt.scratch_page, size, offset);
> 
> 	sg_dma_address(sg) = (dma_addr_t)dev_priv->mm.stolen_base + offset;
> 	sg_dma_len(sg) = size;
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 62584: 76890 | 76922

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.