Attachment 7718 Details for Bug 8960 – valueparam patch

[patch] valueparam patch

0001-Changed-valueparam-arguments-for-attribute-lists.txt (text/plain), 3.51 KB, created by Patrick Guimond on 2006-11-09 13:53:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Guimond

Created: 2006-11-09 13:53:18 UTC

Size: 3.51 KB

patch

obsolete

>From 1a92bfa85136a4d1c2add181b9ba3afa35a06c6b Mon Sep 17 00:00:00 2001
>From: Patrick Guimond <patg@patg.homeunix.org>
>Date: Wed, 8 Nov 2006 17:29:43 -0500
>Subject: [PATCH] Changed valueparam arguments for attribute lists
>
>For following request and replies, substitutes attribute list passing
>to a parameter list instead of valuemask/values
>
>Requests: - CreatePixmap
>          - QueryContext
>          - CreatePbuffer
>          - ChangeDrawableAttributes
>          - CreateWindow
>Reply:    - GetDrawableAttributes
>---
> xcb-proto/src/extensions/glx.xml |   51 ++++++++++++++++++++++++++-----------
> 1 files changed, 36 insertions(+), 15 deletions(-)
>
>diff --git a/xcb-proto/src/extensions/glx.xml b/xcb-proto/src/extensions/glx.xml
>index ba5c253..9c53f80 100644
>--- a/xcb-proto/src/extensions/glx.xml
>+++ b/xcb-proto/src/extensions/glx.xml
>@@ -339,6 +339,12 @@ The patch that fixed this server bug in
> 		<field type="xproto:PIXMAP" name="pixmap" />
> 		<field type="glx:PIXMAP" name="glx_pixmap" />
> 		<field type="CARD32" name="num_attribs" />  
>+		<list type="CARD32" name="attribs">
>+			<op op="*">
>+				<fieldref>num_attribs</fieldref>
>+				<value>2</value>
>+			</op>
>+		</list>
> 	</request>
> 
> 	<request name="DestroyPixmap" opcode="23">
>@@ -362,9 +368,12 @@ The patch that fixed this server bug in
> 			<pad bytes="1" />
> 			<field type="CARD32" name="num_attributes"/>
> 			<pad bytes="20" />
>-			<valueparam value-mask-type="CARD32"
>-				value-mask-name="value_mask"
>-				value-list-name="value_list" />
>+			<list type="CARD32" name="attribs">
>+				<op op="*">
>+					<fieldref>num_attributes</fieldref>
>+					<value>2</value>
>+				</op>
>+			</list>
> 		</reply>
> 	</request>
> 
>@@ -385,9 +394,12 @@ The patch that fixed this server bug in
> 		<field type="FBCONFIG" name="fbconfig" />
> 		<field type="PBUFFER" name="pbuffer" />
> 		<field type="CARD32" name="num_attribs" />
>-		<valueparam value-mask-type="CARD32"
>-			value-mask-name="value_mask"
>-			value-list-name="value_list" />
>+		<list type="CARD32" name="attribs">
>+			<op op="*">
>+				<fieldref>num_attribs</fieldref>
>+				<value>2</value>
>+			</op>
>+		</list>
> 	</request>
> 
> 	<request name="DestroyPbuffer" opcode="28">
>@@ -400,18 +412,24 @@ The patch that fixed this server bug in
> 			<pad bytes="1" />
> 			<field type="CARD32" name="num_attribs" />
> 			<pad bytes="20" />
>-			<valueparam value-mask-type="CARD32"
>-				value-mask-name="value_mask"
>-				value-list-name="value_list" />
>+			<list type="CARD32" name="attribs">
>+				<op op="*">
>+					<fieldref>num_attribs</fieldref>
>+					<value>2</value>
>+				</op>
>+			</list>
> 		</reply>
> 	</request>
> 
> 	<request name="ChangeDrawableAttributes" opcode="30">
> 		<field type="glx:DRAWABLE" name="drawable" />
> 		<field type="CARD32" name="num_attribs" />
>-		<valueparam value-mask-type="CARD32"
>-			value-mask-name="value_mask"
>-			value-list-name="value_list" />
>+		<list type="CARD32" name="attribs">
>+			<op op="*">
>+				<fieldref>num_attribs</fieldref>
>+				<value>2</value>
>+			</op>
>+		</list>
> 	</request>
> 
> 	<request name="CreateWindow" opcode="31">
>@@ -420,9 +438,12 @@ The patch that fixed this server bug in
> 		<field type="xproto:WINDOW" name="window" />
> 		<field type="glx:WINDOW" name="glx_window" />
> 		<field type="CARD32" name="num_attribs" />
>-		<valueparam value-mask-type="CARD32"
>-			value-mask-name="value_mask"
>-			value-list-name="value_list" />
>+		<list type="CARD32" name="attribs">
>+			<op op="*">
>+				<fieldref>num_attribs</fieldref>
>+				<value>2</value>
>+			</op>
>+		</list>
> 	</request>
> 
> 	<request name="DeleteWindow" opcode="32">
>-- 
>1.4.3.4
>

Actions: View | Splinter Review

Attachments on bug 8960: 7718 | 7719 | 7720

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.