Attachment 77185 Details for Bug 62830 – Proposed patch to fix the issue.

[patch] Proposed patch to fix the issue.

fix_62830.patch (text/plain), 1.27 KB, created by Joaquín Ignacio Aramendía on 2013-03-29 06:09:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joaquín Ignacio Aramendía

Created: 2013-03-29 06:09:08 UTC

Size: 1.27 KB

patch

obsolete

>From 2602e4d90f21575d18ad2256e9c14d61c202cb99 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joaqu=C3=ADn=20Ignacio=20Aramend=C3=ADa?=
> <samsagax@gmail.com>
>Date: Fri, 29 Mar 2013 02:56:36 -0300
>Subject: [PATCH] Fix Bug 62830: Increment the register only when mapped.
>
>Otherwise the lights are not rendered properly.
>Reverts bug introduced by commit 7426d9d7699452f15f3288e781e1791d8d00a64a
>---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
>index 273761b..faf33af 100644
>--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
>+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
>@@ -1251,15 +1251,8 @@ fs_visitor::calculate_urb_setup()
>             continue;
> 
> 	 if (c->key.input_slots_valid & BITFIELD64_BIT(i)) {
>-	    /* The back color slot is skipped when the front color is
>-	     * also written to.  In addition, some slots can be
>-	     * written in the vertex shader and not read in the
>-	     * fragment shader.  So the register number must always be
>-	     * incremented, mapped or not.
>-	     */
> 	    if (_mesa_varying_slot_in_fs((gl_varying_slot) i))
>-	       urb_setup[i] = urb_next;
>-            urb_next++;
>+	       urb_setup[i] = urb_next++;
> 	 }
>       }
> 
>-- 
>1.8.2
>

Actions: View | Splinter Review

Attachments on bug 62830: 77170 | 77185

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.