Attachment 77295 Details for Bug 61876 – fix

[patch] fix

0001-win32-fix-corrupted-drawing.patch (text/plain), 2.00 KB, created by Marc-Andre Lureau on 2013-04-01 22:47:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc-Andre Lureau

Created: 2013-04-01 22:47:00 UTC

Size: 2.00 KB

patch

obsolete

>From 840fce30eaa31cf39979e423ea6c7378e9e9b28b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@gmail.com>
>Date: Tue, 2 Apr 2013 00:32:56 +0200
>Subject: [PATCH] win32: fix corrupted drawing
>
>Fix src bitmap coordinates, which origin is bottom-left. This is
>apparently a bug in StretchDIBits(), according to some comments on
>MSDN API documentation.
>
>The backend used to have this coordinate change in the past:
>
>            if (!StretchDIBits (dst->dc,
>                                /* dst x,y,w,h */
>                                dst_r.x, dst_r.y + dst_r.height - 1,
>                                dst_r.width, - (int) dst_r.height,
>                                /* src x,y,w,h */
>                                src_r.x, src_extents.height - src_r.y + 1,
>                                src_r.width, - (int) src_r.height,
>                                src_image->data,
>                                &bi,
>                                DIB_RGB_COLORS,
>                                SRCCOPY))
>
>https://bugs.freedesktop.org/show_bug.cgi?id=61876
>---
> src/win32/cairo-win32-gdi-compositor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/win32/cairo-win32-gdi-compositor.c b/src/win32/cairo-win32-gdi-compositor.c
>index c70b0f9..073e889 100644
>--- a/src/win32/cairo-win32-gdi-compositor.c
>+++ b/src/win32/cairo-win32-gdi-compositor.c
>@@ -151,10 +151,11 @@ static cairo_bool_t upload_box (cairo_box_t *box, void *closure)
>     int y = _cairo_fixed_integer_part (box->p1.y);
>     int width  = _cairo_fixed_integer_part (box->p2.x - box->p1.x);
>     int height = _cairo_fixed_integer_part (box->p2.y - box->p1.y);
>+    int src_height = -cb->bi.bmiHeader.biHeight;
> 
>     TRACE ((stderr, "%s\n", __FUNCTION__));
>     return StretchDIBits (cb->dst, x, y + height - 1, width, -height,
>-			  x + cb->tx,  height - (y + cb->ty - 1),
>+			  x + cb->tx,  src_height - (y + cb->ty - 1),
> 			  width, -height,
> 			  cb->data, &cb->bi,
> 			  DIB_RGB_COLORS, SRCCOPY);
>-- 
>1.8.1.1.439.g50a6b54
>

Actions: View | Splinter Review

Attachments on bug 61876: 75988 | 76798 | 77295

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.