Attachment 77717 Details for Bug 63353 – patch to fix flush input

[patch] patch to fix flush input

0001-xf86-fix-flush-input-to-work-with-Linux-evdev-device.patch (text/plain), 1.14 KB, created by Dave Airlie on 2013-04-10 06:12:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Airlie

Created: 2013-04-10 06:12:22 UTC

Size: 1.14 KB

patch

obsolete

>From 88394b5cf39f298ebaa9a8ce4ace9bef14c2c6ee Mon Sep 17 00:00:00 2001
>From: Dave Airlie <airlied@gmail.com>
>Date: Wed, 10 Apr 2013 16:09:01 +1000
>Subject: [PATCH] xf86: fix flush input to work with Linux evdev devices.
>
>So when we VT switch back and attempt to flush the input devices,
>we don't succeed because evdev won't return part of an event,
>since we were only asking for 4 bytes, we'd only get -EINVAL back.
>
>This could later cause events to be flushed that we shouldn't have
>gotten.
>
>This is a fix for CVE-2013-1940.
>
>Signed-off-by: Dave Airlie <airlied@redhat.com>
>---
> hw/xfree86/os-support/shared/posix_tty.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/hw/xfree86/os-support/shared/posix_tty.c b/hw/xfree86/os-support/shared/posix_tty.c
>index ab3757a..4d08c1e 100644
>--- a/hw/xfree86/os-support/shared/posix_tty.c
>+++ b/hw/xfree86/os-support/shared/posix_tty.c
>@@ -421,7 +421,8 @@ xf86FlushInput(int fd)
> {
>     fd_set fds;
>     struct timeval timeout;
>-    char c[4];
>+    /* this needs to be big enough to flush an evdev event. */
>+    char c[256];
> 
>     DebugF("FlushingSerial\n");
>     if (tcflush(fd, TCIFLUSH) == 0)
>-- 
>1.8.2
>

Actions: View | Splinter Review

Attachments on bug 63353: 77717

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.