Attachment 77857 Details for Bug 63189 – Proposed patch

[patch] Proposed patch

0001-core-device.c-fix-possible-segfault.patch (text/plain), 1.30 KB, created by Harald Hoyer on 2013-04-12 10:01:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harald Hoyer

Created: 2013-04-12 10:01:19 UTC

Size: 1.30 KB

patch

obsolete

>From 0de1434abc8bc11f27d3372dafe3b09095f6c094 Mon Sep 17 00:00:00 2001
>From: Harald Hoyer <harald@redhat.com>
>Date: Fri, 12 Apr 2013 11:56:27 +0200
>Subject: [PATCH] core/device.c: fix possible segfault
>
>https://bugs.freedesktop.org/show_bug.cgi?id=63189
>
>better fail than segfault
>
>systemd[1]: Failed to load device unit: Invalid argument
>systemd[1]: Failed to process udev device event: Invalid argument
>---
> src/core/device.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/src/core/device.c b/src/core/device.c
>index fb94868..abb6a05 100644
>--- a/src/core/device.c
>+++ b/src/core/device.c
>@@ -312,6 +312,7 @@ fail:
> static int device_process_new_device(Manager *m, struct udev_device *dev, bool update_state) {
>         const char *sysfs, *dn;
>         struct udev_list_entry *item = NULL, *first = NULL;
>+        int r;
> 
>         assert(m);
> 
>@@ -319,7 +320,9 @@ static int device_process_new_device(Manager *m, struct udev_device *dev, bool u
>                 return -ENOMEM;
> 
>         /* Add the main unit named after the sysfs path */
>-        device_update_unit(m, dev, sysfs, true);
>+        r = device_update_unit(m, dev, sysfs, true);
>+        if (r)
>+                return r;
> 
>         /* Add an additional unit for the device node */
>         if ((dn = udev_device_get_devnode(dev)))
>-- 
>1.8.2
>

Actions: View | Splinter Review

Attachments on bug 63189: 77857

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.