Attachment 78412 Details for Bug 63871 – Remove newlines from debug messages

[patch] Remove newlines from debug messages

Remove-newlines-from-debug-messages.patch (text/plain), 4.30 KB, created by Stef Walter on 2013-04-24 09:14:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stef Walter

Created: 2013-04-24 09:14:01 UTC

Size: 4.30 KB

patch

obsolete

>From 7eb6b296ad1a510ea9f3423b929adedf83636292 Mon Sep 17 00:00:00 2001
>From: Stef Walter <stefw@redhat.com>
>Date: Wed, 24 Apr 2013 11:13:17 +0200
>Subject: [PATCH] Remove newlines from debug messages
>
>g_debug() doesn't need to be passed a new line
>
>https://bugs.freedesktop.org/show_bug.cgi?id=63871
>---
> src/daemon.c | 12 ++++++------
> src/main.c   |  2 +-
> src/user.c   |  4 ++--
> src/util.c   |  2 +-
> 4 files changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/src/daemon.c b/src/daemon.c
>index 7486b84..c25d39f 100644
>--- a/src/daemon.c
>+++ b/src/daemon.c
>@@ -654,7 +654,7 @@ reload_autologin_timeout (Daemon *daemon)
>         }
> 
>         if (enabled) {
>-                g_debug ("automatic login is enabled for '%s'\n", name);
>+                g_debug ("automatic login is enabled for '%s'", name);
>                 if (daemon->priv->autologin != user) {
>                         g_object_set (user, "automatic-login", TRUE, NULL);
>                         daemon->priv->autologin = g_object_ref (user);
>@@ -662,7 +662,7 @@ reload_autologin_timeout (Daemon *daemon)
>                 }
>         }
>         else {
>-                g_debug ("automatic login is disabled\n");
>+                g_debug ("automatic login is disabled");
>         }
> 
>         g_free (name);
>@@ -952,7 +952,7 @@ daemon_local_find_user_by_name (Daemon      *daemon,
> 
>         pwent = getpwnam (name);
>         if (pwent == NULL) {
>-                g_debug ("unable to lookup name %s", name);
>+                g_debug ("unable to lookup name %s: %s", name, g_strerror (errno));
>                 return NULL;
>         }
> 
>@@ -1050,16 +1050,16 @@ finish_list_cached_users (gpointer user_data)
>                 shell = user_get_shell (user);
> 
>                 if (user_get_system_account (user)) {
>-                        g_debug ("user %s %ld is system account, so excluded\n", name, (long) uid);
>+                        g_debug ("user %s %ld is system account, so excluded", name, (long) uid);
>                         continue;
>                 }
> 
>                 if (daemon_local_user_is_excluded (data->daemon, name, shell, NULL)) {
>-                        g_debug ("user %s %ld excluded\n", name, (long) uid);
>+                        g_debug ("user %s %ld excluded", name, (long) uid);
>                         continue;
>                 }
> 
>-                g_debug ("user %s %ld not excluded\n", name, (long) uid);
>+                g_debug ("user %s %ld not excluded", name, (long) uid);
>                 g_ptr_array_add (object_paths, (gpointer) user_get_object_path (user));
>         }
>         g_ptr_array_add (object_paths, NULL);
>diff --git a/src/main.c b/src/main.c
>index ac8ef00..2fcddb6 100644
>--- a/src/main.c
>+++ b/src/main.c
>@@ -213,7 +213,7 @@ main (int argc, char *argv[])
>         g_unix_signal_add (SIGINT, on_signal_quit, loop);
>         g_unix_signal_add (SIGTERM, on_signal_quit, loop);
> 
>-        g_debug ("entering main loop\n");
>+        g_debug ("entering main loop");
>         g_main_loop_run (loop);
> 
>         g_debug ("exiting");
>diff --git a/src/user.c b/src/user.c
>index bf5939c..6386855 100644
>--- a/src/user.c
>+++ b/src/user.c
>@@ -1085,14 +1085,14 @@ user_change_icon_file_authorized_cb (Daemon                *daemon,
>         g_object_unref (file);
> 
>         if (type != G_FILE_TYPE_REGULAR) {
>-                g_debug ("not a regular file\n");
>+                g_debug ("not a regular file");
>                 throw_error (context, ERROR_FAILED, "file '%s' is not a regular file", filename);
>                 g_free (filename);
>                 return;
>         }
> 
>         if (size > 1048576) {
>-                g_debug ("file too large\n");
>+                g_debug ("file too large");
>                 /* 1MB ought to be enough for everybody */
>                 throw_error (context, ERROR_FAILED, "file '%s' is too large to be used as an icon", filename);
>                 g_free (filename);
>diff --git a/src/util.c b/src/util.c
>index 2e363a3..642b32c 100644
>--- a/src/util.c
>+++ b/src/util.c
>@@ -259,7 +259,7 @@ get_user_groups (const gchar  *user,
>         ngroups = 0;
>         res = getgrouplist (user, group, NULL, &ngroups);
> 
>-        g_debug ("user %s has %d groups\n", user, ngroups);
>+        g_debug ("user %s has %d groups", user, ngroups);
>         *groups = g_new (gid_t, ngroups);
>         res = getgrouplist (user, group, *groups, &ngroups);
> 
>-- 
>1.8.1.4

Actions: View | Splinter Review

Attachments on bug 63871: 78412

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.