Attachment 78433 Details for Bug 63857 – make iga[12]_crtc_mode_fixup more verbose when the mode is rejected

[patch] make iga[12]_crtc_mode_fixup more verbose when the mode is rejected

0001-make-iga-12-_crtc_mode_fixup-more-verbose-when-the-m.patch (text/plain), 2.71 KB, created by Xavier Bachelot on 2013-04-24 17:30:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Xavier Bachelot

Created: 2013-04-24 17:30:21 UTC

Size: 2.71 KB

patch

obsolete

>From 27ab741f8ee1b39dfae48f8e089cc9a344ece823 Mon Sep 17 00:00:00 2001
>From: Xavier Bachelot <xavier@bachelot.org>
>Date: Mon, 8 Apr 2013 22:33:10 +0200
>Subject: [PATCH] make iga[12]_crtc_mode_fixup more verbose when the mode is
> rejected.
>
>---
> src/via_display.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
>diff --git a/src/via_display.c b/src/via_display.c
>index 267a9c1..a5f645b 100644
>--- a/src/via_display.c
>+++ b/src/via_display.c
>@@ -908,16 +908,26 @@ iga1_crtc_mode_fixup(xf86CrtcPtr crtc, DisplayModePtr mode,
>     ScrnInfoPtr pScrn = crtc->scrn;
>     VIAPtr pVia = VIAPTR(pScrn);
>     CARD32 temp;
>+    ModeStatus modestatus;
> 
>     if (pVia->pVbe)
>         return TRUE;
> 
>     if ((mode->Clock < pScrn->clockRanges->minClock) ||
>-        (mode->Clock > pScrn->clockRanges->maxClock))
>+        (mode->Clock > pScrn->clockRanges->maxClock)) {
>+        xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>+                   "Clock for mode \"%s\" outside of allowed range (%u (%u - %u))\n",
>+                   mode->name, mode->Clock, pScrn->clockRanges->minClock,
>+                   pScrn->clockRanges->maxClock);
>         return FALSE;
>+    } 
> 
>-    if (ViaFirstCRTCModeValid(pScrn, mode) != MODE_OK)
>+    modestatus = ViaFirstCRTCModeValid(pScrn, mode);
>+    if (modestatus != MODE_OK) {
>+        xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Not using mode \"%s\" : %s.\n",
>+                   mode->name, xf86ModeStatusToString(modestatus));
>         return FALSE;
>+    }
> 
>     temp = mode->CrtcHDisplay * mode->CrtcVDisplay * mode->VRefresh *
>             (pScrn->bitsPerPixel >> 3);
>@@ -1309,16 +1319,26 @@ iga2_crtc_mode_fixup(xf86CrtcPtr crtc, DisplayModePtr mode,
>     ScrnInfoPtr pScrn = crtc->scrn;
>     VIAPtr pVia = VIAPTR(pScrn);
>     CARD32 temp;
>+    ModeStatus modestatus;
> 
>     if (pVia->pVbe)
>         return TRUE;
> 
>     if ((mode->Clock < pScrn->clockRanges->minClock) ||
>-        (mode->Clock > pScrn->clockRanges->maxClock))
>+        (mode->Clock > pScrn->clockRanges->maxClock)) {
>+        xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>+                   "Clock for mode \"%s\" outside of allowed range (%u (%u - %u))\n",
>+                   mode->name, mode->Clock, pScrn->clockRanges->minClock,
>+                   pScrn->clockRanges->maxClock);
>         return FALSE;
>+    }
> 
>-    if (ViaSecondCRTCModeValid(pScrn, mode) != MODE_OK)
>+    modestatus = ViaFirstCRTCModeValid(pScrn, mode);
>+    if (modestatus != MODE_OK) {
>+        xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Not using mode \"%s\" : %s.\n",
>+                   mode->name, xf86ModeStatusToString(modestatus));
>         return FALSE;
>+    }
> 
>     temp = mode->CrtcHDisplay * mode->CrtcVDisplay * mode->VRefresh *
>             (pScrn->bitsPerPixel >> 3);
>-- 
>1.8.1.4
>

Actions: View | Splinter Review

Attachments on bug 63857: 78428 | 78429 | 78430 | 78431 | 78433 | 78553 | 79175 | 79177 | 79178 | 79179 | 79180 | 79181 | 79182 | 79555 | 79567 | 79578

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.