Attachment 78519 Details for Bug 54489 – Fine tune the --os-name and --os-version arguments

[patch] Fine tune the --os-name and --os-version arguments

Fine-tune-the---os-name-and---os-version-arguments.patch (text/plain), 1.19 KB, created by Stef Walter on 2013-04-26 11:38:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stef Walter

Created: 2013-04-26 11:38:27 UTC

Size: 1.19 KB

patch

obsolete

>From 46361aa1366ce9def894249cfbc926585d24e328 Mon Sep 17 00:00:00 2001
>From: Stef Walter <stefw@redhat.com>
>Date: Fri, 12 Apr 2013 21:16:25 +0200
>Subject: [PATCH] Fine tune the --os-name and --os-version arguments
>
>The values should be required
>
>https://bugs.freedesktop.org/show_bug.cgi?id=54489
>---
> tools/computer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tools/computer.c b/tools/computer.c
>index 3f97e16..44d31f3 100644
>--- a/tools/computer.c
>+++ b/tools/computer.c
>@@ -287,8 +287,8 @@ adcli_tool_computer_join (adcli_conn *conn,
> 		{ "domain-ou", required_argument, NULL, opt_domain_ou },
> 		{ "computer-ou", required_argument, NULL, opt_domain_ou }, /* compat */
> 		{ "service-name", required_argument, NULL, opt_service_name },
>-		{ "os-name", optional_argument, NULL, opt_os_name },
>-		{ "os-version", optional_argument, NULL, opt_os_version },
>+		{ "os-name", required_argument, NULL, opt_os_name },
>+		{ "os-version", required_argument, NULL, opt_os_version },
> 		{ "os-service-pack", optional_argument, NULL, opt_os_service_pack },
> 		{ "user-principal", optional_argument, NULL, opt_user_principal },
> 		{ "show-details", no_argument, NULL, opt_show_details },
>-- 
>1.8.2.1

Actions: View | Splinter Review

Attachments on bug 54489: 77732 | 77814 | 77823 | 77841 | 78519

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.