Attachment 79029 Details for Bug 59771 – Avoid overcounting fences for self-relocs

[patch] Avoid overcounting fences for self-relocs

0001-intel-Avoid-overcounting-fences-when-emitting-self-r.patch (text/plain), 1.65 KB, created by Chris Wilson on 2013-05-08 16:45:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2013-05-08 16:45:15 UTC

Size: 1.65 KB

patch

obsolete

>From d8a55101520dde138566e9bebdf7103a6ed95ec9 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Wed, 8 May 2013 16:30:44 +0100
>Subject: [PATCH] intel: Avoid overcounting fences when emitting
> self-referential relocs
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> intel/intel_bufmgr_gem.c |   15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
>diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
>index 6ebeec9..ccedeab 100644
>--- a/intel/intel_bufmgr_gem.c
>+++ b/intel/intel_bufmgr_gem.c
>@@ -1652,6 +1652,14 @@ do_bo_emit_reloc(drm_intel_bo *bo, uint32_t offset,
> 	assert(offset <= bo->size - 4);
> 	assert((write_domain & (write_domain - 1)) == 0);
> 
>+	/* An object needing a fence is a tiled buffer, so it won't have
>+	 * relocs to other buffers.
>+	 */
>+	if (need_fence) {
>+		assert(target_bo_gem->reloc_count == 0);
>+		target_bo_gem->reloc_tree_fences = 1;
>+	}
>+
> 	/* Make sure that we're not adding a reloc to something whose size has
> 	 * already been accounted for.
> 	 */
>@@ -1659,13 +1667,8 @@ do_bo_emit_reloc(drm_intel_bo *bo, uint32_t offset,
> 	if (target_bo_gem != bo_gem) {
> 		target_bo_gem->used_as_reloc_target = true;
> 		bo_gem->reloc_tree_size += target_bo_gem->reloc_tree_size;
>+		bo_gem->reloc_tree_fences += target_bo_gem->reloc_tree_fences;
> 	}
>-	/* An object needing a fence is a tiled buffer, so it won't have
>-	 * relocs to other buffers.
>-	 */
>-	if (need_fence)
>-		target_bo_gem->reloc_tree_fences = 1;
>-	bo_gem->reloc_tree_fences += target_bo_gem->reloc_tree_fences;
> 
> 	bo_gem->relocs[bo_gem->reloc_count].offset = offset;
> 	bo_gem->relocs[bo_gem->reloc_count].delta = target_offset;
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 59771: 75820 | 79029

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.